Skip to content

Conversation

@gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Feb 15, 2024

Description

... and inject it to MarketServiceManager and investor-foxy, to avoid multiple instantiations that trigger calls to eth_chainId.
No batching, but less requests in the end, which means things are effectively faster and more performant.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

Engineering

  • Compare network tab against develop
  • Ensure we don't spam eth_chainId payloads aymore

Operations

Screenshots (if applicable)

Develop

  • 113 daemon.ethereum XHRs
Screenshot 2024-02-15 at 15 27 22
  • Chatty eth_chainId
image image image image image

And many, many more

This diff

  • 95 daemon.ethereum XHRs
Screenshot 2024-02-15 at 15 23 42
  • Not-so-chatty eth_chainId

Now only called once by BaseTransactionParser

image image

Copy link
Contributor Author

gomesalexandre commented Feb 15, 2024

@gomesalexandre gomesalexandre marked this pull request as ready for review February 15, 2024 15:06
@gomesalexandre gomesalexandre requested a review from a team as a code owner February 15, 2024 15:06
@gomesalexandre gomesalexandre mentioned this pull request Feb 15, 2024
14 tasks
@woodenfurniture woodenfurniture force-pushed the feat_ethers_provider_no_module_eval branch from 4565503 to a85f27c Compare February 19, 2024 11:26
Base automatically changed from feat_ethers_provider_no_module_eval to develop February 19, 2024 11:26
@gomesalexandre gomesalexandre force-pushed the feat_switch_static_json_rpc_provider branch from ab15bed to 5a0dd6d Compare February 19, 2024 14:00
@gomesalexandre gomesalexandre enabled auto-merge (squash) February 19, 2024 17:25
@gomesalexandre gomesalexandre merged commit 61ee963 into develop Feb 19, 2024
@gomesalexandre gomesalexandre deleted the feat_switch_static_json_rpc_provider branch February 19, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants