Skip to content

Conversation

@0xApotheosis
Copy link
Member

@0xApotheosis 0xApotheosis commented Feb 19, 2024

feat: thorchain lending 100% repayment buffer (#6238)
feat: unify Tx allowance logic (#6217)
revert fix: temporarily disable eip-1559 for keepkey (#6254)
chore: bump hdwallet v1.53.4 (#6255)
chore: cut over nownodes prod (#6251)
feat: switch ethers JSON-RPC provider to StaticJsonRpcProvider (#6223)
fix: remove all hardcoded SwapperName.Thorchain in isTradingActive ch… (#6237)
chore: add validation for quotes with incorrect sell amount (#6241)
fix: trades from native assets & utxos (#6260)

woodenfurniture and others added 8 commits February 19, 2024 14:51
* feat: unify Tx allowance logic

* feat: cleaner

* feat: refactor useIsApprovalNeeded to use a selector on
allowanceCryptobaseUnit

* feat: cleanup

* feat: more cleanup

* feat: cleanup

* chore: do not inline types

* feat: more cleanup

* feat: cleanup unused type

* feat: consume selectAllowanceCryptoBaseUnit in useIsApprovalNeeded

* feat: extract GetAllowanceErr in react-queries/types

---------

Co-authored-by: kaladinlight <35275952+kaladinlight@users.noreply.github.com>
Co-authored-by: Apotheosis <97164662+0xApotheosis@users.noreply.github.com>
@MBMaria
Copy link

MBMaria commented Feb 20, 2024

Blocker:

  • Unable to trade out of AVAX. "Confirm and Trade" button spins indefinitely
    image

Not sure if a blocker but i have no unlocked loans that i can test the repay amount . Do we trust the withdraw that @gomesalexandre did when testing the PR itself?

Discord testing thread: https://discord.com/channels/554694662431178782/1209280550926553118

@0xApotheosis
Copy link
Member Author

The above blocker should be resolved by #6260.

…#6265)

* fix: allow quote sell amounts to be lower than user input sell amount

* fix: fix logic, add a teeny tiny thrshold so cowswap works
@MBMaria
Copy link

MBMaria commented Feb 21, 2024

blocker:

@MBMaria
Copy link

MBMaria commented Feb 21, 2024

Non blocker:

  • approval txid's not appearing in trade modal flow:
    release:
    image
    image
    Prod:
    image
    image

#6270

@0xApotheosis 0xApotheosis merged commit 0c57db1 into main Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants