-
Notifications
You must be signed in to change notification settings - Fork 394
[deps] Pandoc 3.8.3, typst 0.14.2 #13249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
@tarleb It seems that there's a |
|
Sorry, I hadn't seen this. I'll try to be there today. |
|
@tarleb suggests |
On further thought, this only works if we know that the replacement for the shortcode is in a position where this escaping is required. In order to do that, we would have to enrich the LPEG parser to learn about parsing links and images, and then to process shortcodes differently inside links and images. That's a pretty large undertaking. |
|
I've pushed a fix: page inset needs to be typst raw inline. Most of the other failures seem to be because we need to update the Typst templates from Pandoc to get Skylighting support. Not trivial as there's a bunch of new stuff, but not that bad. |
for pandoc 3.8 next: investigate why this case enables syntax-highlighting
|
Importing So all the stuff I need to update (merging Chris Kenny's improvements with brand yaml, basically) is not reflected in tests. TL;DR We've been applying Now syntax highlighting will match by default! Claude's explanation:Quarto always sets highlight-style for ALL formats, including typst:
Before pandoc 3.8/3.9: This didn't matter because pandoc ignored the highlight-style for typst and used typst's native highlighting. After pandoc 3.8/3.9: Pandoc now respects --syntax-highlighting for typst output, so quarto's default "arrow" style triggers skylighting for ALL code blocks, including unlanguaged ones (wrapped in NormalTok). What is
|
|
Thanks @gordonwoodhull! What I mentioned yesterday is also that Pandoc now uses
So I think we need to check if we use that flag, and probably anticipate the end of deprecation warning in our default file use.
The new option is now Currently we use And maybe in other places. Should we do this in another PR maybe ? It is kind of part of the pandoc update though. |
|
I am just updating to benefit from new condensed logging |
|
I think the biggest cause of failures right now if from a LaTeX change in how table counters work in the Pandoc writer and templates. I still don't understand how to avoid that problem. |
|
Oh, I have dealt with that recently for the rticles R package. I needed to add the missing template part to the rticles' built-in template (rstudio/rticles#596) They do something in the Writer that expects something in the template. It could be either this template addition, or some adaptation in the way we create the table. Also related, this change in Pandoc is for ensuring that unlabelled tables don't increment counter. I remember this was a problem in cross ref with counter workaround to decrement or something, so it could be now conflicting with what Pandoc is doing. Hope it helps understand. (Disclaimer: I did not look at failing examples, just what I looked for my rticles maintainance about this) |
Brings: