Skip to content

fix(204): add #nullable enabled directive on top of generated file #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomflenner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(204): add #nullable enabled directive on top of generated file #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/cmd/testdata/success_csharp.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// AUTOMATICALLY GENERATED BY OPENFEATURE CLI, DO NOT EDIT.
#nullable enable
using System;
using System.Collections.Generic;
using System.Threading.Tasks;
Expand Down
1 change: 1 addition & 0 deletions internal/generators/csharp/csharp.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// AUTOMATICALLY GENERATED BY OPENFEATURE CLI, DO NOT EDIT.
#nullable enable
Copy link

@gemini-code-assist gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This directive enables nullable reference types in C#. It's good practice to include a comment explaining why this is necessary for maintainability.

Consider adding a brief comment to explain the purpose of this directive.

#nullable enable // Enable nullable reference types to ensure null-safety in generated code

using System;
using System.Collections.Generic;
using System.Threading.Tasks;
Expand Down
1 change: 1 addition & 0 deletions test/csharp-integration/OpenFeature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// AUTOMATICALLY GENERATED BY OPENFEATURE CLI, DO NOT EDIT.
#nullable enable
using System;
using System.Collections.Generic;
using System.Threading.Tasks;
Expand Down
1 change: 1 addition & 0 deletions test/csharp-integration/OpenFeature.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// AUTOMATICALLY GENERATED BY OPENFEATURE CLI, DO NOT EDIT.
#nullable enable
using System;
using System.Collections.Generic;
using System.Threading.Tasks;
Expand Down
1 change: 1 addition & 0 deletions test/csharp-integration/expected/OpenFeature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// AUTOMATICALLY GENERATED BY OPENFEATURE CLI, DO NOT EDIT.
#nullable enable
using System;
using System.Collections.Generic;
using System.Threading.Tasks;
Expand Down
1 change: 1 addition & 0 deletions test/csharp-integration/expected/OpenFeature.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// AUTOMATICALLY GENERATED BY OPENFEATURE CLI, DO NOT EDIT.
#nullable enable
using System;
using System.Collections.Generic;
using System.Threading.Tasks;
Expand Down