Skip to content

Conversation

@tomflenner
Copy link

@tomflenner tomflenner commented Jan 30, 2026

This PR

Adds #nullable enable directive at the top of the generated C# file to provide explicit nullable annotations context required by the compiler.

This resolves CS8669 compilation errors that occur when using the generated code in projects with <TreatWarningsAsErrors>true</TreatWarningsAsErrors> enabled.

Related Issues

Fixes #204

Notes

  • The #nullable enable directive is added to the beginning of OpenFeature.g.cs
  • This allows the generated code to compile successfully in projects that treat warnings as errors
  • No changes to the actual generated code logic, only adds the required compiler directive

How to test

  1. Create a C# project with <TreatWarningsAsErrors>true</TreatWarningsAsErrors> in the .csproj file
  2. Generate C# code using the OpenFeature CLI code generator with this fix
  3. Build the project
  4. Verify that the CS8669 error no longer occurs
  5. Alternatively, clone the reproduction repo at https://github.com/tomflenner/openfeature-cli-sharp-repro and test with the updated generator

This avoid CS8669 warnings

Signed-off-by: backtrack5r3 <flennertom@gmail.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello @tomflenner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the C# code generation process by addressing a common compilation issue related to nullable reference types. By injecting the #nullable enable directive into the generated C# files, it ensures that projects with stringent warning-as-error configurations can seamlessly integrate the generated code without encountering build failures, thereby improving overall compatibility and developer experience.

Highlights

  • Nullable Reference Types: The #nullable enable directive has been added to the top of all generated C# files. This explicitly enables nullable annotations context for the C# compiler.
  • Compilation Error Resolution: This change resolves the CS8669 compilation error that occurs in C# projects where <TreatWarningsAsErrors>true</TreatWarningsAsErrors> is enabled, ensuring generated code compiles successfully under strict warning policies.
  • Code Generation Template Update: The core change is implemented in the csharp.tmpl file, ensuring that all future C# code generated by the OpenFeature CLI will include the #nullable enable directive by default.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@tomflenner tomflenner force-pushed the 204-fix-csharp-generated-file branch from 14c4a38 to d90ae5b Compare January 30, 2026 16:17
@tomflenner tomflenner changed the title fix(202): add #nullable enabled directive on top of generated file fix(204): add #nullable enabled directive on top of generated file Jan 30, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the #nullable enable directive to the top of generated C# files to enable explicit nullable annotations. This resolves CS8669 compilation errors in projects with <TreatWarningsAsErrors>true enabled. The change is applied to the template and existing generated files.

@@ -1,4 +1,5 @@
// AUTOMATICALLY GENERATED BY OPENFEATURE CLI, DO NOT EDIT.
#nullable enable

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This directive enables nullable reference types in C#. It's good practice to include a comment explaining why this is necessary for maintainability.

Consider adding a brief comment to explain the purpose of this directive.

#nullable enable // Enable nullable reference types to ensure null-safety in generated code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: warning as errror CS8669 on csharp generated file

1 participant