Skip to content

Add BE Peppol localization with Enterprise No. support #6268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Copilot wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add BE Peppol localization with Enterprise No. support #6268

Copilot wants to merge 10 commits into from
+908 −9

Conversation

Copy link
Contributor

Copilot AI commented Jan 23, 2026 •
edited by github-actions bot
Loading

Belgium PEPPOL requires two deviations from W1: VAT registration numbers must use FormatEnterpriseNo for BE companies, and document validation must accept "Enterprise No." as alternative to GLN/VAT Registration No.

Changes

New App: src/Apps/BE/Peppol

PEPPOL Party Info Provider Implementation (PEPPOL30 BE)

  • Overrides all methods that internally call FormatVATRegistrationNo to use BE-specific logic
  • For BE countries, applies FormatEnterpriseNo which prepends ISO code only to numeric-only enterprise numbers
if IsBelgiumCountry(CountryCode) then
    VATRegistrationNo := FormatEnterpriseNo(VATRegistrationNo, CountryCode)

Validation Implementation (PEPPOL30 BE Sales Validation)

  • Extends company/customer validation to include Enterprise No.:
if CompanyInfo.GLN + CompanyInfo."VAT Registration No." + GetEnterpriseNo(CompanyInfo) = '' then
    Error(MissingCompInfGLNOrVATRegNoOrEnterpNoErr, ...);
  • Integration events: OnCheckSalesDocumentOnBeforeCheckCompanyVATRegNo, OnCheckSalesDocumentOnBeforeCheckCustomerVATRegNo

Enum Extension (PEPPOL 3.0 Format BE)

  • Registers PEPPOL 3.0 - BE Sales and PEPPOL 3.0 - BE Service with BE implementations

Copilot AI and others added 2 commits January 23, 2026 16:53
@Groenbech96
Add BE Peppol app with Belgium-specific VAT registration formatting
c2d726e 
Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>
@Groenbech96
Add clarifying comments to FormatEnterpriseNo procedure
2d9e1d6 
Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>
Copilot AI changed the title [WIP] Override GetAccountingSupplierPartyTaxScheme method for Peppol app Add BE Peppol app with Belgium-specific VAT registration formatting Jan 23, 2026
Copilot AI requested a review from Groenbech96 January 23, 2026 16:55
Copilot AI and others added 2 commits January 23, 2026 17:01
@Groenbech96
Add BE-specific validation with Enterprise No. check
135553e 
Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>
@Groenbech96
Refactor: Consolidate duplicate helper functions
80b2550 
Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>
Copilot AI changed the title Add BE Peppol app with Belgium-specific VAT registration formatting Add BE Peppol app with Enterprise No. validation and VAT formatting Jan 23, 2026
@Groenbech96
Fix FormatVATRegistrationNo delegation - override all affected methods
e3e8baa 
Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>
Copilot AI changed the title Add BE Peppol app with Enterprise No. validation and VAT formatting Add BE Peppol localization with Enterprise No. support Jan 23, 2026
Groenbech96
Groenbech96 requested changes Jan 26, 2026
View reviewed changes
@Groenbech96
Changes before error encountered
8e42a0f 
Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>
Copilot AI requested a review from Groenbech96 January 26, 2026 10:38
@Groenbech96
Copy link
Contributor

Groenbech96 commented Jan 26, 2026

@copilot try again

@Groenbech96
Copy link
Contributor

Groenbech96 commented Jan 26, 2026

@copilot try again

@Groenbech96
Copy link
Contributor

Groenbech96 commented Jan 26, 2026

@copilot try again

@github-actions github-actions bot added the AL: Apps (W1) Add-on apps for W1 label Jan 26, 2026
@github-actions
Copy link

github-actions bot commented Jan 26, 2026

Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234'

@Groenbech96 Groenbech96 marked this pull request as ready for review January 26, 2026 13:33
@Groenbech96 Groenbech96 requested review from a team as code owners January 26, 2026 13:33
Copilot AI mentioned this pull request Jan 27, 2026
Merged
@Groenbech96
Add missing BE Service format for PEPPOL export (#6312)
941e9cb 
PR #6268 implements BE-specific PEPPOL export (Enterprise No.
formatting/validation) but only for Sales documents. Service documents
would fall through to W1 implementation, missing Belgium Enterprise No.
support entirely.

## Changes

- **Added** `PEPPOL30 BE Service Validation` codeunit (37312) -
delegates to BE Sales validation via service→sales conversion (mirrors
W1 pattern)
- **Extended** `PEPPOL 3.0 Format BE` enum with `"PEPPOL 3.0 - BE
Service"` value (37311) implementing BE Party Info Provider + BE Service
Validation
- **Updated** subscriber to set both `"PEPPOL 3.0 Sales Format"` and
`"PEPPOL 3.0 Service Format"` on setup insert

## Format Selection Flow

```al
// Export codeunits read setup and dispatch to format implementation
Exp. Sales Inv. PEPPOL30   → Setup."PEPPOL 3.0 Sales Format"   → PEPPOL30 BE → FormatEnterpriseNo ✓
Exp. Serv.Inv. PEPPOL30    → Setup."PEPPOL 3.0 Service Format" → PEPPOL30 BE → FormatEnterpriseNo ✓
                                                            (was: PEPPOL30 W1 → No Enterprise No.)
```

Both document types now apply BE-specific:
- `FormatEnterpriseNo`: Prepends ISO code to numeric-only enterprise
numbers
- Validation: Accepts GLN **OR** VAT Reg No. **OR** Enterprise No. (W1
only accepts first two)

<!-- START COPILOT CODING AGENT SUFFIX -->



<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> Pull Request: #6268
> 
> Please analyse how/if this app correctly overrides behaviour of the W1
app when user executes the export of sales or services docs.
> 


</details>



<!-- START COPILOT CODING AGENT TIPS -->
---

💡 You can make Copilot smarter by setting up custom instructions,
customizing its development environment and configuring Model Context
Protocol (MCP) servers. Learn more [Copilot coding agent
tips](https://gh.io/copilot-coding-agent-tips) in the docs.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>
@Groenbech96
Copy link
Contributor

Groenbech96 commented Jan 27, 2026

@copilot Error: Clashing object IDs detected: codeunit 37312
Exception: Object ID validation failed. When adding new test objects, ensure that their IDs are within the valid range and do not
clash with existing object IDs.
Error: Process completed with exit code 1.

Copilot AI requested a review from Groenbech96 January 27, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Groenbech96 Groenbech96 Awaiting requested review from Groenbech96

At least 2 approving reviews are required to merge this pull request.

Assignees

@Groenbech96 Groenbech96

Copilot code review Copilot

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Groenbech96