Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 27, 2026

PR #6268 implements BE-specific PEPPOL export (Enterprise No. formatting/validation) but only for Sales documents. Service documents would fall through to W1 implementation, missing Belgium Enterprise No. support entirely.

Changes

  • Added PEPPOL30 BE Service Validation codeunit (37312) - delegates to BE Sales validation via service→sales conversion (mirrors W1 pattern)
  • Extended PEPPOL 3.0 Format BE enum with "PEPPOL 3.0 - BE Service" value (37311) implementing BE Party Info Provider + BE Service Validation
  • Updated subscriber to set both "PEPPOL 3.0 Sales Format" and "PEPPOL 3.0 Service Format" on setup insert

Format Selection Flow

// Export codeunits read setup and dispatch to format implementation
Exp. Sales Inv. PEPPOL30   → Setup."PEPPOL 3.0 Sales Format"   → PEPPOL30 BE → FormatEnterpriseNo ✓
Exp. Serv.Inv. PEPPOL30    → Setup."PEPPOL 3.0 Service Format" → PEPPOL30 BE → FormatEnterpriseNo ✓
                                                            (was: PEPPOL30 W1 → No Enterprise No.)

Both document types now apply BE-specific:

  • FormatEnterpriseNo: Prepends ISO code to numeric-only enterprise numbers
  • Validation: Accepts GLN OR VAT Reg No. OR Enterprise No. (W1 only accepts first two)
Original prompt

Pull Request: #6268

Please analyse how/if this app correctly overrides behaviour of the W1 app when user executes the export of sales or services docs.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Groenbech96 <17690329+Groenbech96@users.noreply.github.com>
Copilot AI changed the title [WIP] Analyze export behavior override of W1 app Add missing BE Service format for PEPPOL export Jan 27, 2026
Copilot AI requested a review from Groenbech96 January 27, 2026 08:35
Copy link
Contributor

@Groenbech96 Groenbech96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Groenbech96 Groenbech96 marked this pull request as ready for review January 27, 2026 15:18
@Groenbech96 Groenbech96 requested a review from a team as a code owner January 27, 2026 15:18
@Groenbech96 Groenbech96 merged commit 941e9cb into copilot/overwrite-get-accounting-supplier-tax-scheme Jan 27, 2026
1 check passed
@Groenbech96 Groenbech96 deleted the copilot/analyze-export-behavior branch January 27, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants