Skip to content

Suppress or address errors from a forthcoming Error Prone check that looks for calls like containsExactly(null) that always throw NPE. #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 13, 2025
+10 −3
Merged

Suppress or address errors from a forthcoming Error Prone check that looks for calls like containsExactly(null) that always throw NPE. #1611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions core/src/test/java/com/google/common/truth/IterableSubjectTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import static com.google.common.truth.Truth.assertThat;
import static java.lang.String.CASE_INSENSITIVE_ORDER;
import static java.util.Arrays.asList;
import static java.util.Collections.singleton;
import static org.junit.Assert.assertThrows;

import com.google.common.collect.ImmutableList;
Expand Down Expand Up @@ -814,10 +815,12 @@ public void containsExactlyWithDuplicatesOutOfOrder() {
}

@Test
// We intentionally test the behavior of the method under a call that will soon fail.
@SuppressWarnings("NullNeedsCastForVarargs")
@J2ktIncompatible // Kotlin can't pass a null array for a varargs parameter
public void containsExactlyWithOnlyNullPassedAsNullArray() {
// Truth is tolerant of this erroneous varargs call.
Iterable<Object> actual = asList((Object) null);
Iterable<Object> actual = singleton(null);
// We are changing Truth from tolerating this erroneous varargs call to not tolerating it.
try {
assertThat(actual).containsExactly((Object[]) null);
} catch (NullPointerException e) {
Expand Down
6 changes: 5 additions & 1 deletion core/src/test/java/com/google/common/truth/StreamSubjectTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import static com.google.common.truth.FailureAssertions.assertFailureValue;
import static com.google.common.truth.Truth.assertThat;
import static java.util.Arrays.asList;
import static java.util.Collections.singleton;

import java.util.stream.Stream;
import org.junit.Test;
Expand Down Expand Up @@ -316,8 +317,11 @@ public void containsExactly_nullObject() {

@Test
@J2ktIncompatible // Kotlin can't pass a null array for a varargs parameter
// We intentionally test the behavior of the method under a call that will soon fail.
@SuppressWarnings("NullNeedsCastForVarargs")
public void containsExactly_nullObjectArray() {
StreamSubject subject = assertThat(Stream.of((Object) null));
StreamSubject subject = assertThat(singleton(null).stream());
// We are changing Truth from tolerating this erroneous varargs call to not tolerating it.
try {
subject.containsExactly((Object[]) null);
} catch (NullPointerException e) {
Expand Down