Suppress or address errors from a forthcoming Error Prone check that looks for calls like containsExactly(null) that always throw NPE.
#1611
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_818740054
branch
from
0af6f2d to
f52e448
Compare
copybara-service
bot
changed the title
asList(null) that always throw NPE.containsExactly(null) that always throw NPE.
…looks for calls like `containsExactly(null)` that always throw NPE. (To check for a list that contains only a null element, the calls will soon need to be `containsExactly((Object) null)` (with a cast to the array's _element_ type), not `containsExactly(null)` or `containsExactly((Object[]) null)` (with a cast to the _array_ type).) Also, sidestep other null-varargs fun by using `Collections.singleton` instead of the varargs methods `Arrays.asList` and `Stream.of`.) ([the check](google/error-prone#5263)) PiperOrigin-RevId: 818803000
copybara-service
bot
force-pushed
the
test_818740054
branch
from
f52e448 to
611972f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress or address errors from a forthcoming Error Prone check that looks for calls like
containsExactly(null)that always throw NPE.(To check for a list that contains only a null element, the calls will soon need to be
containsExactly((Object) null)(with a cast to the array's element type), notcontainsExactly(null)orcontainsExactly((Object[]) null)(with a cast to the array type).)Also, sidestep other null-varargs fun by using
Collections.singletoninstead of the varargs methodsArrays.asListandStream.of.)(the check)