feat: fees parameters frontend #1265
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughThe changes replace the single consensus rotation configuration with a more granular fee-based structure, introducing new parameters for leader timeout, validators timeout, appeal rounds, and rotations. This update propagates through environment configuration, store state, component props, and contract interaction logic, and introduces new types and modular input components for handling these settings. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ConsensusSection
participant ConsensusInputSection
participant consensusStore
participant RunDebugView
participant ConstructorParameters
participant ContractWriteMethods
participant useContractQueries
participant Backend
User->>ConsensusSection: Update fee input
ConsensusSection->>ConsensusInputSection: Pass input config
ConsensusInputSection->>consensusStore: Call setter with new value
consensusStore-->>ConsensusInputSection: Update state and persist
ConsensusSection-->>RunDebugView: Store reflects new fees
RunDebugView->>ConstructorParameters: Pass feesDistribution prop
RunDebugView->>ContractWriteMethods: Pass feesDistribution prop
ConstructorParameters->>useContractQueries: Deploy contract with feesDistribution
ContractWriteMethods->>useContractQueries: Call write method with feesDistribution
useContractQueries->>Backend: Send contract call with feesDistribution
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~45 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
kstroobants
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #DXP-443
What
consensusMaxRotationswithfeesDistributionin various components..env.examplefile, includingVITE_LEADER_TIMEOUT_FEE,VITE_VALIDATORS_TIMEOUT_FEE,VITE_APPEAL_ROUNDS_FEE, andVITE_ROTATIONS_FEE.ConsensusInputSectioncomponent to manage consensus input settings.useConsensusStoreto handle new fee-related state and logic.Why
To add fees.
Testing done
Verified that the new fee settings are correctly loaded and stored in local storage.
Decisions made
Decided to store fee settings in local storage for persistence across sessions.
Checks
Reviewing tips
Focus on the changes.
Depends on
Implementation of DXP-445. That is why tests are failing.
User facing release notes
Introduced a fee structure for the consensus mechanism.
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Refactor
Bug Fixes
Chores