-
Notifications
You must be signed in to change notification settings - Fork 28
feat: fees mechanism on/off #1266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes restructure the consensus configuration in both environment and frontend code, replacing the single Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ConsensusSection
participant ConsensusStore
participant RunDebugView
participant ContractComponent
User->>ConsensusSection: Toggle fees, input fee values
ConsensusSection->>ConsensusStore: setFeesEnabled/setFee values
User->>RunDebugView: Initiate contract deploy/write
RunDebugView->>ContractComponent: Pass feesDistribution prop
ContractComponent->>useContractQueries: Deploy/write with feesDistribution
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~45 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|


Fixes #DXP-444
What
undefinedfor fees to deploy and write method and hides the fee fields.feesEnabledstate in theconsensusStoreto manage the toggle state.feesDistributionprop to be optional in several components.useContractQuerieshook to handle the optionalfeesDistribution.Why
To provide users with the ability to enable or disable fees dynamically.
Testing done
undefinedis sent and fee fields are hidden.Decisions made
Checks
Reviewing tips
Focus on the changes.
Depends on
This PR contains code from PR #1265.
Tests are failing because it depends on genlayer-js DXP-445.
User facing release notes
Summary by CodeRabbit
New Features
Improvements
Refactor