Skip to content

Planner: drop deprecated publishing keys (BC) #26293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
andig wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Planner: drop deprecated publishing keys (BC) #26293

andig wants to merge 10 commits into from

Conversation

@andig
Copy link
Member

@andig andig commented Dec 31, 2025 •
edited
Loading

Follow-up to #24423, depends on #26291.

TODO

  • ui

@andig andig added the enhancement New feature or request label Dec 31, 2025
sourcery-ai[bot]
sourcery-ai bot reviewed Dec 31, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @andig, your pull request is larger than the review limit of 150000 diff characters

@andig andig changed the title Feat/ps Planner: drop deprecated publishing keys (BC) Dec 31, 2025
@andig andig mentioned this pull request Dec 31, 2025
Draft
1 task
@andig andig requested a review from naltatis December 31, 2025 13:02
naltatis
naltatis approved these changes Dec 31, 2025
View reviewed changes
Copy link
Member

@naltatis naltatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andig
Copy link
Member Author

andig commented Dec 31, 2025

Failed aber :O

@naltatis
Copy link
Member

naltatis commented Dec 31, 2025 

Error:   1) [chromium] › tests/plan.spec.ts:632:3 › repeating › repeating plan persistence ────────────────

    Retry #3 ───────────────────────────────────────────────────────────────────────────────────────
    Error: expect(locator).toHaveValue(expected) failed

    Locator:  getByTestId('charging-plan-modal').first().getByLabel('Late Charging')
    Expected: "7200"
    Received: "5769811253"

Looks like unit conversion issue. I'll check.

@naltatis
Copy link
Member

naltatis commented Dec 31, 2025

@andig maybe one step back. Whats the actual goal this PR tries to achieve? We have multiple things at play here. Contintinuous/Precondition values on loadpoint and vehicle level and also effective values combining both.

@andig
Copy link
Member Author

andig commented Dec 31, 2025

An effective hat der PR noch nix geändert, das wäre aber der nächste Schritt. Alles möge über die neuen Keys laufen.

@andig andig marked this pull request as draft December 31, 2025 13:39
@iseeberg79
Copy link
Contributor

iseeberg79 commented Dec 31, 2025

ich könnte den verbleibenden UI Umbau vorschlagen, wenn's hilfreich ist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@naltatis naltatis naltatis approved these changes

Assignees

@naltatis naltatis

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andig @naltatis @iseeberg79