-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: use json/v2 #24937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: use json/v2 #24937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@Maschga I was expecting this PR to be a no-up. Could you figure out why the tests break? Maywe we've not providing the JSON expected after all? |
|
The problem is that now |
Because I've generally changed this to match precondition and others. Could I ask you to open a new PR to export duration in seconds in order to do this consistently everywhere? |
|
I don't quite understand what you mean by |
|
With this PR- and in future- we will always un/marshal time.Duration in JSON in seconds. Today, it‘s mixed- planner in seconds, sessions in ns. To fix this, we can make it consistent today or with this PR. In both cases, we‘ll need to change the sessions behaviour of the UI wich expects nano-seconds atm. |
TODO
planStrategy(replace Planner: drop deprecated publishing keys (BC) #26293)