fix(i2c): guard I2C_NUM_1 usage for single-port targets (ESP32-C3) #568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#ifdef I2C_NUM_1guards ini2c_format_helpers.hpp.I2C_NUM_1is compiled only when the target SoC actually supports a second I2C port.Motivation and Context
Single-port SoCs like the ESP32-C3 do not define
I2C_NUM_1.Currently, including the I2C component on an ESP32-C3 target causes a build failure because the formatter attempts to reference
I2C_NUM_1unconditionally. This change ensures compatibility with targets that possess onlyI2C_NUM_0.How has this been tested?
I tested this on an ESP32-C3 target.
idf.py buildfor an ESP32-C3 project includingespp::I2c.'I2C_NUM_1' was not declared in this scope.Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.Hardware