Refactor Grafana dashboard to use server_name label
#19337
Draft
+235
−187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Grafana dashboard to use
server_namelabelPreviously, the recommendation was to use the
instancelabel to group everything under the same server:synapse/docs/metrics-howto.md
Lines 93 to 147 in 803e4b4
But the
instancelabel actually has a special meaning and we're actually abusing it by using it that way:Since #18592 (Synapse
v1.139.0), we now have theserver_namelabel.Additionally, the assumption that a single process is serving a single server is no longer true with Synapse Pro for small hosts.
Part of https://github.com/element-hq/synapse-small-hosts/issues/106
Motivating use case
This change is spawning from adding Prometheus metrics to our workerized Docker image (#19324, #19336) with a more correct label setup (without
instance) and wanting the dashboard to be better.Todo
server_namevariable to dashboardprocess_metricsdeploysannotationPull Request Checklist
EventStoretoEventWorkerStore.".code blocks.