Skip to content

refactor: remove noise files from test coverage #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
poltorak wants to merge 2 commits into
base: main
Choose a base branch
from
+67 −5
Open

refactor: remove noise files from test coverage #1214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc0abc0
refactor: remove noise files from test coverage
Jan 12, 2026
bd747d0
refactor: improve excluded coverage files list
Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/utils/mocks/sink.mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Sink } from '../src/lib/sink-source.types';
import type { Sink } from '../src/lib/sink-source.type';

export class MockSink implements Sink<string, string> {
private writtenItems: string[] = [];
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/src/lib/performance-observer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
type PerformanceObserverEntryList,
performance,
} from 'node:perf_hooks';
import type { Buffered, Encoder, Observer, Sink } from './sink-source.types.js';
import type { Buffered, Encoder, Observer, Sink } from './sink-source.type';

export const DEFAULT_FLUSH_THRESHOLD = 20;

Expand Down
0 packages/utils/src/lib/sink-source.types.ts → packages/utils/src/lib/sink-source.type.ts
View file
Open in desktop
File renamed without changes.
28 changes: 27 additions & 1 deletion testing/test-setup-config/src/lib/vitest-config-factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,33 @@ function buildCoverageConfig(
return undefined;
}

const exclude = ['mocks/**', '**/types.ts', 'perf/**'];
const exclude = [
'tests/**',
'perf/**',
// Mocks and fixtures
'mocks/**',
'**/fixtures/**',
'**/*.mock.ts',
'**/*.fixture.ts',
// Config files
'**/vitest.*.config.ts',
'**/vitest.config.ts',
'**/code-pushup.config.ts',
'**/*.config.ts',
// Barrel files (index files that only re-export)
'**/index.ts',
'**/index.js',
'**/index.mjs',
// Model files
'**/models.ts',
'**/*.model.ts',
'**/types.ts',
'**/*.type.ts',
// Constants
'**/constants.ts',
// typings
'**/*.d.ts',
];
const reportsDirectory = `../../coverage/${projectKey}/${kind}-tests`;

return {
Expand Down
40 changes: 38 additions & 2 deletions testing/test-setup-config/src/lib/vitest-config-factory.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,27 @@ describe('createVitestConfig', () => {
coverage: expect.objectContaining({
reporter: ['text', 'lcov'],
reportsDirectory: '../../coverage/test-package/unit-tests',
exclude: ['mocks/**', '**/types.ts', 'perf/**'],
exclude: [
'tests/**',
'perf/**',
'mocks/**',
'**/fixtures/**',
'**/*.mock.ts',
'**/*.fixture.ts',
'**/vitest.*.config.ts',
'**/vitest.config.ts',
'**/code-pushup.config.ts',
'**/*.config.ts',
'**/index.ts',
'**/index.js',
'**/index.mjs',
'**/models.ts',
'**/*.model.ts',
'**/types.ts',
'**/*.type.ts',
'**/constants.ts',
'**/*.d.ts',
],
}),
typecheck: { include: ['**/*.type.test.ts'] },
}),
Expand Down Expand Up @@ -270,9 +290,25 @@ describe('createVitestConfig', () => {
const config = createVitestConfig('test-package', 'unit');

expect(config.test!.coverage!.exclude).toEqual([
'tests/**',
'perf/**',
'mocks/**',
'**/fixtures/**',
'**/*.mock.ts',
'**/*.fixture.ts',
'**/vitest.*.config.ts',
'**/vitest.config.ts',
'**/code-pushup.config.ts',
'**/*.config.ts',
'**/index.ts',
'**/index.js',
'**/index.mjs',
'**/models.ts',
'**/*.model.ts',
'**/types.ts',
'perf/**',
'**/*.type.ts',
'**/constants.ts',
'**/*.d.ts',
]);
});
});
Expand Down