-
Notifications
You must be signed in to change notification settings - Fork 15
refactor: remove noise files from test coverage #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit fc0abc0
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/models
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit c7e50a8 with previous commit 7d3681c. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 2 groups regressed, 👍 3 audits improved, 👎 3 audits regressed, 15 audits changed without impacting score🗃️ Groups
31 other groups are unchanged. 🛡️ Audits
658 other audits are unchanged. |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit c7e50a8 with previous commit 7d3681c. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 90 | 🟢 96 |
5 other categories are unchanged.
👍 1 group improved, 👍 2 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 90 | 🟢 96 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟨 82.5 % | 🟩 97.2 % | |
| Code coverage | Branch coverage | 🟨 73.7 % | 🟨 88.2 % |
442 other audits are unchanged.
💼 Project plugin-jsdocs
🥳 Code PushUp report has improved.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 95 | 🟢 97 |
5 other categories are unchanged.
👍 1 group improved, 👍 2 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 95 | 🟢 97 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟩 90.5 % | 🟩 96.5 % | |
| Code coverage | Branch coverage | 🟨 87.9 % | 🟩 92.7 % |
442 other audits are unchanged.
💼 Project nx-plugin
🥳 Code PushUp report has improved.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟡 89 | 🟢 91 |
5 other categories are unchanged.
👍 1 group improved, 👍 2 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟡 89 | 🟢 91 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟨 84.8 % | 🟩 93.3 % | |
| Code coverage | Branch coverage | 🟨 76.3 % | 🟨 79.9 % |
446 other audits are unchanged.
💼 Project plugin-typescript
🥳 Code PushUp report has improved.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟡 86 | 🟡 87 |
5 other categories are unchanged.
👍 1 group improved, 👍 2 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟡 86 | 🟡 87 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟩 90.7 % | 🟩 96.1 % | |
| Code coverage | Branch coverage | 🟨 77.7 % | 🟨 81.1 % |
442 other audits are unchanged.
💼 Project plugin-axe
🥳 Code PushUp report has improved.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 93 | 🟢 94 |
5 other categories are unchanged.
👍 1 group improved, 👍 2 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 93 | 🟢 94 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟨 86.3 % | 🟩 90.1 % | |
| Code coverage | Line coverage | 🟨 69.7 % | 🟨 72.7 % |
441 other audits are unchanged.
💼 Project cli
🥳 Code PushUp report has improved.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 92 | 🟢 94 |
5 other categories are unchanged.
👍 1 group improved, 👍 2 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 92 | 🟢 94 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟨 88.5 % | 🟩 94.5 % | |
| Code coverage | Branch coverage | 🟨 84.2 % | 🟨 86.7 % |
442 other audits are unchanged.
💼 Project models
🥳 Code PushUp report has improved.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 93 | 🟢 94 |
3 other categories are unchanged.
👍 1 group improved, 👍 2 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 93 | 🟢 94 |
11 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟩 91.5 % | 🟩 94.2 % | |
| Code coverage | Line coverage | 🟩 97.2 % | 🟩 99.4 % |
435 other audits are unchanged.
💼 Project ci
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 92 | 🟢 92 |
5 other categories are unchanged.
👍 1 group improved, 👍 2 audits improved, 👎 1 audit regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 92 | 🟢 92 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟨 89.7 % | 🟩 94.8 % | |
| Code coverage | Branch coverage | 🟨 82.4 % | 🟨 83.6 % | |
| Code coverage | Function coverage | 🟩 96.6 % | 🟩 96.6 % |
442 other audits are unchanged.
💼 Project core
🥳 Code PushUp report has improved.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟡 90 | 🟢 90 |
5 other categories are unchanged.
👍 1 group improved, 👍 2 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟡 90 | 🟢 90 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟩 91.2 % | 🟩 94.8 % | |
| Code coverage | Branch coverage | 🟨 81.7 % | 🟨 83.2 % |
442 other audits are unchanged.
💼 Project plugin-coverage
🥳 Code PushUp report has improved.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟡 89 | 🟢 90 |
5 other categories are unchanged.
👍 1 group improved, 👍 2 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟡 89 | 🟢 90 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟨 85.7 % | 🟨 88.1 % | |
| Code coverage | Branch coverage | 🟨 88.1 % | 🟨 89.6 % |
442 other audits are unchanged.
💼 Project plugin-js-packages
🥳 Code PushUp report has improved.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟡 85 | 🟡 86 |
5 other categories are unchanged.
👍 1 group improved, 👍 2 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟡 85 | 🟡 86 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟩 93.3 % | 🟩 95 % | |
| Code coverage | Line coverage | 🟨 85 % | 🟨 86.5 % |
442 other audits are unchanged.
💼 Project plugin-eslint
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 94 | 🟢 94 |
5 other categories are unchanged.
👍 1 group improved, 👍 2 audits improved, 👎 1 audit regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 94 | 🟢 94 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟩 92.6 % | 🟩 95 % | |
| Code coverage | Branch coverage | 🟨 85.2 % | 🟨 86.5 % | |
| Code coverage | Function coverage | 🟩 98.2 % | 🟩 98.2 % |
441 other audits are unchanged.
💼 Project plugin-lighthouse
🥳 Code PushUp report has improved.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 99 | 🟢 99 |
5 other categories are unchanged.
👍 1 group improved, 👍 2 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 99 | 🟢 99 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟩 97.2 % | 🟩 99.6 % | |
| Code coverage | Branch coverage | 🟩 96.2 % | 🟩 97.1 % |
442 other audits are unchanged.
💼 Project utils
🥳 Code PushUp report has improved.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 94 | 🟢 95 | |
| Documentation | 🔴 36 | 🔴 36 |
4 other categories are unchanged.
👍 2 groups improved, 👍 2 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 94 | 🟢 95 | |
| JSDocs coverage | Documentation coverage | 🔴 36 | 🔴 36 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟩 93.8 % | 🟩 94.8 % | |
| Code coverage | Branch coverage | 🟩 91.8 % | 🟩 92.1 % |
442 other audits are unchanged.
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added suggestio for type handling and including the tests folder.
| 'mocks/**', | ||
| 'perf/**', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 'mocks/**', | |
| 'perf/**', | |
| 'mocks/**', | |
| 'tests/**', | |
| 'perf/**', |
As our e2e tests all are placed in tests folders.
| '**/models.ts', | ||
| '**/*.model.ts', | ||
| '**/types.ts', | ||
| '**/*.types.ts', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a naming convention like we do have with *.mock.ts in tests.
ATM in our. repo there are *.types.ts and *.type.ts and types.ts.
We could agree on having only *.type.ts and types.ts and standardise the repo.
|
Another idea... we could run-many unit-test and int test and ask AI to analyse for noise files. If it works the prompt could be attached to the PR description. |
Covers part 3 of #1168
Added more files to be excluded in test coverage report