Skip to content

Conversation

@poltorak
Copy link
Collaborator

Covers part 3 of #1168

Added more files to be excluded in test coverage report

@poltorak poltorak requested a review from BioPhoton January 12, 2026 14:06
@poltorak poltorak self-assigned this Jan 12, 2026
@github-actions github-actions bot added the 🔬 testing writing tests label Jan 12, 2026
@nx-cloud
Copy link

nx-cloud bot commented Jan 12, 2026

View your CI Pipeline Execution ↗ for commit fc0abc0

Command Status Duration Result
nx affected -t e2e-test --parallel=1 ✅ Succeeded 12m 44s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-12 15:43:31 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 12, 2026

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1214

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1214

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1214

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1214

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1214

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1214

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1214

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1214

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1214

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1214

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1214

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1214

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1214

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1214

commit: fc0abc0

@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit c7e50a8 with previous commit 7d3681c.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 37 🔴 36 ↓ −1.5
Code coverage 🟢 91 🟢 92 ↑ +0.8
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Documentation 🔴 34 🔴 34 ↓ −0.1
Code style 🟢 99 🟢 99
Security 🟡 51 🟡 51
Updates 🟡 78 🟡 78
Type Safety 🟡 67 🟡 67
Miscellaneous 🟡 67 🟡 67
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 1 group improved, 👎 2 groups regressed, 👍 3 audits improved, 👎 3 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 37 🔴 36 ↓ −1.5
Code coverage Code coverage metrics 🟢 91 🟢 92 ↑ +0.8
JSDocs coverage Documentation coverage 🔴 34 🔴 34 ↓ −0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 5.9 s 🟥 6.7 s ↑ +14.5 %
Lighthouse First Contentful Paint 🟥 3.0 s 🟥 3.2 s ↑ +5.7 %
Code coverage Line coverage 🟨 86.2 % 🟨 89.2 % ↑ +3.5 %
Code coverage Branch coverage 🟨 87.3 % 🟨 88.9 % ↑ +1.8 %
Lighthouse Total Blocking Time 🟥 1,990 ms 🟥 1,880 ms ↓ −5.7 %
Code coverage Function coverage 🟩 93.4 % 🟩 93.4 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,113 KiB 🟩 Total size was 2,105 KiB ↓ −0.3 %
Lighthouse Server Backend Latencies 🟩 1,050 ms 🟩 230 ms ↓ −77.8 %
Lighthouse Largest Contentful Paint 🟥 11.4 s 🟥 11.0 s ↓ −3.8 %
Lighthouse JavaScript execution time 🟥 4.4 s 🟥 4.0 s ↓ −9.4 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 95 KiB 🟥 Potential savings of 95 KiB ↓ −25 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 200 KiB 🟥 Potential savings of 223 KiB ↓ −14.2 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 103 KiB 🟥 Potential savings of 108 KiB ↓ −33.3 %
Lighthouse Initial server response time was short 🟩 Root document took 400 ms 🟩 Root document took 540 ms ↑ +34.8 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +0.6 %
Lighthouse Time to Interactive 🟥 13.0 s 🟥 13.1 s ↑ +0.6 %
Lighthouse Minimizes main-thread work 🟥 8.9 s 🟥 8.9 s ↓ −0.5 %
Lighthouse Max Potential First Input Delay 🟥 1,040 ms 🟥 1,080 ms ↑ +3.7 %
Lighthouse Network Round Trip Times 🟩 0 ms 🟩 10 ms ↑ +44.9 %
JS packages Outdated npm dev dependencies. 🟨 55 outdated package versions (29 major, 19 minor, 7 patch) 🟨 56 outdated package versions (29 major, 19 minor, 8 patch) ↑ +1.8 %

658 other audits are unchanged.

@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit c7e50a8 with previous commit 7d3681c.

💼 Project create-cli

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 90 🟢 96 ↑ +5.8

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 90 🟢 96 ↑ +5.8

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟨 82.5 % 🟩 97.2 % ↑ +17.9 %
Code coverage Branch coverage 🟨 73.7 % 🟨 88.2 % ↑ +19.7 %

442 other audits are unchanged.

💼 Project plugin-jsdocs

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 95 🟢 97 ↑ +2

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 95 🟢 97 ↑ +2

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟩 90.5 % 🟩 96.5 % ↑ +6.7 %
Code coverage Branch coverage 🟨 87.9 % 🟩 92.7 % ↑ +5.5 %

442 other audits are unchanged.

💼 Project nx-plugin

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 89 🟢 91 ↑ +1.9

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 89 🟢 91 ↑ +1.9

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟨 84.8 % 🟩 93.3 % ↑ +9.9 %
Code coverage Branch coverage 🟨 76.3 % 🟨 79.9 % ↑ +4.7 %

446 other audits are unchanged.

💼 Project plugin-typescript

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 86 🟡 87 ↑ +1.6

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 86 🟡 87 ↑ +1.6

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟩 90.7 % 🟩 96.1 % ↑ +5.9 %
Code coverage Branch coverage 🟨 77.7 % 🟨 81.1 % ↑ +4.4 %

442 other audits are unchanged.

💼 Project plugin-axe

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 93 🟢 94 ↑ +1.4

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 93 🟢 94 ↑ +1.4

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟨 86.3 % 🟩 90.1 % ↑ +4.4 %
Code coverage Line coverage 🟨 69.7 % 🟨 72.7 % ↑ +4.3 %

441 other audits are unchanged.

💼 Project cli

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 92 🟢 94 ↑ +1.4

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 92 🟢 94 ↑ +1.4

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟨 88.5 % 🟩 94.5 % ↑ +6.8 %
Code coverage Branch coverage 🟨 84.2 % 🟨 86.7 % ↑ +3 %

442 other audits are unchanged.

💼 Project models

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 93 🟢 94 ↑ +1

3 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 93 🟢 94 ↑ +1

11 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟩 91.5 % 🟩 94.2 % ↑ +2.9 %
Code coverage Line coverage 🟩 97.2 % 🟩 99.4 % ↑ +2.2 %

435 other audits are unchanged.

💼 Project ci

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 92 🟢 92 ↑ +0.9

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 92 🟢 92 ↑ +0.9

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟨 89.7 % 🟩 94.8 % ↑ +5.7 %
Code coverage Branch coverage 🟨 82.4 % 🟨 83.6 % ↑ +1.5 %
Code coverage Function coverage 🟩 96.6 % 🟩 96.6 % ↓ −0.1 %

442 other audits are unchanged.

💼 Project core

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 90 🟢 90 ↑ +0.8

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 90 🟢 90 ↑ +0.8

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟩 91.2 % 🟩 94.8 % ↑ +3.9 %
Code coverage Branch coverage 🟨 81.7 % 🟨 83.2 % ↑ +1.8 %

442 other audits are unchanged.

💼 Project plugin-coverage

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 89 🟢 90 ↑ +0.7

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 89 🟢 90 ↑ +0.7

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟨 85.7 % 🟨 88.1 % ↑ +2.8 %
Code coverage Branch coverage 🟨 88.1 % 🟨 89.6 % ↑ +1.7 %

442 other audits are unchanged.

💼 Project plugin-js-packages

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 85 🟡 86 ↑ +0.7

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 85 🟡 86 ↑ +0.7

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟩 93.3 % 🟩 95 % ↑ +1.8 %
Code coverage Line coverage 🟨 85 % 🟨 86.5 % ↑ +1.8 %

442 other audits are unchanged.

💼 Project plugin-eslint

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 94 🟢 94 ↑ +0.6

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 94 🟢 94 ↑ +0.6

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟩 92.6 % 🟩 95 % ↑ +2.5 %
Code coverage Branch coverage 🟨 85.2 % 🟨 86.5 % ↑ +1.5 %
Code coverage Function coverage 🟩 98.2 % 🟩 98.2 % ↓ −0.1 %

441 other audits are unchanged.

💼 Project plugin-lighthouse

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 99 🟢 99 ↑ +0.5

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 99 🟢 99 ↑ +0.5

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟩 97.2 % 🟩 99.6 % ↑ +2.5 %
Code coverage Branch coverage 🟩 96.2 % 🟩 97.1 % ↑ +1 %

442 other audits are unchanged.

💼 Project utils

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 94 🟢 95 ↑ +0.2
Documentation 🔴 36 🔴 36 ↑ +0.1

4 other categories are unchanged.

👍 2 groups improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 94 🟢 95 ↑ +0.2
JSDocs coverage Documentation coverage 🔴 36 🔴 36 ↑ +0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟩 93.8 % 🟩 94.8 % ↑ +1 %
Code coverage Branch coverage 🟩 91.8 % 🟩 92.1 % ↑ +0.2 %

442 other audits are unchanged.

Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestio for type handling and including the tests folder.

Comment on lines +35 to +36
'mocks/**',
'perf/**',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'mocks/**',
'perf/**',
'mocks/**',
'tests/**',
'perf/**',

As our e2e tests all are placed in tests folders.

'**/models.ts',
'**/*.model.ts',
'**/types.ts',
'**/*.types.ts',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a naming convention like we do have with *.mock.ts in tests.
ATM in our. repo there are *.types.ts and *.type.ts and types.ts.
We could agree on having only *.type.ts and types.ts and standardise the repo.

@BioPhoton
Copy link
Collaborator

Another idea... we could run-many unit-test and int test and ask AI to analyse for noise files. If it works the prompt could be attached to the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔬 testing writing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants