Skip to content

Conversation

@Tobbe
Copy link
Member

@Tobbe Tobbe commented Jan 4, 2026

  • Upgrade all github actions to use node24
  • Properly pass canary to the test project actions
  • Install canary first, and then tarsync

@github-actions github-actions bot added this to the chore milestone Jan 4, 2026
@netlify
Copy link

netlify bot commented Jan 4, 2026

Deploy Preview for cedarjs canceled.

Name Link
🔨 Latest commit b5d857a
🔍 Latest deploy log https://app.netlify.com/projects/cedarjs/deploys/695a2f46f4986800081b586c

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 4, 2026

Greptile Summary

This PR upgrades all GitHub Actions from Node 20 to Node 24 and fixes a critical bug where the canary input parameter was being ignored.

Key Changes:

  • Updated 8 GitHub Action definitions to use node24 runtime instead of node20
  • Fixed bug in setUpTestProject.mjs and setUpTestProjectEsm.mjs where canary: true was hardcoded, causing the action to always use canary builds regardless of input
  • Refactored script structure by removing unnecessary main() wrapper and sharedTasks() function, calling setUpTestProject({ canary }) directly with the actual input value
  • Moved yarn project:tarsync execution to run after the canary upgrade (if applicable), which ensures dependencies are synced with the correct version
  • Updated workflow files to explicitly set canary: false, which will now work correctly due to the bug fix
  • Minor code cleanup: removed eslint-env comments, improved variable declarations, and simplified console.log formatting

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk - it fixes a bug and updates infrastructure configuration
  • The changes are straightforward: upgrading Node runtime versions in CI configuration and fixing a logic bug where user input was ignored. The bug fix ensures the canary parameter actually controls behavior instead of being hardcoded. The refactoring improves code clarity without changing core logic. All changes are in CI/testing infrastructure, not production code.
  • No files require special attention

Important Files Changed

Filename Overview
.github/actions/set-up-test-project-esm/setUpTestProjectEsm.mjs Fixed canary option bug, refactored code structure, and moved tarsync execution after canary upgrade
.github/actions/set-up-test-project/setUpTestProject.mjs Fixed canary option bug, refactored code structure, and moved tarsync execution after canary upgrade
.github/workflows/background-jobs-e2e.yml Changed canary option from true to false for background jobs E2E tests
.github/workflows/fragments-smoke-tests.yml Changed canary option from true to false for fragments smoke tests

Sequence Diagram

sequenceDiagram
    participant GHA as GitHub Actions Workflow
    participant Action as set-up-test-project Action
    participant Script as setUpTestProject.mjs
    participant FS as File System
    participant Yarn as Yarn Commands

    Note over GHA,Yarn: Node 24 Runtime Environment

    GHA->>Action: Execute with canary input (true/false)
    Action->>Script: Run with node24
    
    Script->>Script: Read canary input via core.getInput()
    Script->>Script: Call setUpTestProject({ canary })
    
    Script->>FS: Copy test project fixture
    FS-->>Script: Project created
    
    alt canary === true
        Script->>Yarn: yarn cedar upgrade -t canary
        Yarn-->>Script: Project upgraded to canary
    end
    
    Script->>Yarn: yarn project:tarsync --verbose
    Yarn-->>Script: Dependencies synced
    
    Script->>Yarn: yarn cedar g secret --raw
    Yarn-->>Script: Secret generated
    Script->>FS: Append SESSION_SECRET to .env
    
    Script->>Yarn: yarn cedar prisma migrate reset --force
    Yarn-->>Script: Database reset complete
    
    Script-->>Action: Setup complete
    Action-->>GHA: Test project ready
Loading

@nx-cloud
Copy link

nx-cloud bot commented Jan 4, 2026

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit b5d857a

Command Status Duration Result
nx run-many -t build:pack --exclude create-ceda... ✅ Succeeded 2s View ↗
nx run-many -t build ✅ Succeeded 5s View ↗
nx run-many -t test --minWorkers=1 --maxWorkers=4 ✅ Succeeded 3s View ↗
nx run-many -t test:types ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-04 09:31:59 UTC

@Tobbe Tobbe merged commit 8e7b821 into main Jan 4, 2026
43 checks passed
@Tobbe Tobbe deleted the tobbe-ci-node24-canary branch January 4, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants