Skip to content

Conversation

@Tobbe
Copy link
Member

@Tobbe Tobbe commented Jan 4, 2026

I don't think we actually used the canary build before because of a bug in our tooling. See #926

Now that canary: true works again, I'm switching to false here to speed things up – upgrading to canary takes time.

@netlify
Copy link

netlify bot commented Jan 4, 2026

Deploy Preview for cedarjs canceled.

Name Link
🔨 Latest commit b5b7f3a
🔍 Latest deploy log https://app.netlify.com/projects/cedarjs/deploys/695a365ce88128000870efaf

@github-actions github-actions bot added this to the chore milestone Jan 4, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 4, 2026

Greptile Summary

This PR changes the SSR smoke tests workflow to skip the canary upgrade step by setting canary: false instead of canary: true. This aligns the SSR smoke tests with other test workflows like background-jobs-e2e.yml and fragments-smoke-tests.yml, which also use canary: false.

Key changes:

  • Disabled canary upgrade in .github/workflows/ssr-smoke-tests.yml
  • Tests will now run against the local framework code instead of upgrading to the canary release first
  • Reduces test execution time by skipping the yarn cedar upgrade -t canary step
  • Makes SSR tests consistent with other smoke test workflows in the repository

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change is a simple, single-line configuration update that aligns SSR smoke tests with other test workflows in the repository. It only affects CI test behavior by skipping an optional canary upgrade step. The change follows established patterns in the codebase and has no impact on production code or runtime behavior.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/ssr-smoke-tests.yml Changed canary flag from true to false to skip canary upgrade during SSR smoke tests, aligning with other workflows

Sequence Diagram

sequenceDiagram
    participant GHA as GitHub Actions
    participant SSR as SSR Smoke Tests
    participant Setup as set-up-test-project
    participant Project as Test Project
    participant Tests as Playwright Tests

    GHA->>SSR: Trigger workflow
    SSR->>Setup: Call with canary: false
    Setup->>Project: Copy test fixture
    Note over Setup,Project: Skip canary upgrade
    Setup->>Project: Run tarsync
    Setup->>Project: Generate dbAuth secret
    Setup->>Project: Run prisma migrate
    Setup-->>SSR: Return test-project-path
    SSR->>Project: Run SSR codemods
    SSR->>Tests: Install Playwright
    SSR->>Tests: Run DEV smoke tests
    SSR->>Project: Build for production
    SSR->>Tests: Run PROD smoke tests
    Tests-->>GHA: Return results
Loading

@nx-cloud
Copy link

nx-cloud bot commented Jan 4, 2026

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit b5b7f3a

Command Status Duration Result
nx run-many -t build:pack --exclude create-ceda... ✅ Succeeded 8s View ↗
nx run-many -t build ✅ Succeeded 8s View ↗
nx run-many -t test --minWorkers=1 --maxWorkers=4 ✅ Succeeded 2s View ↗
nx run-many -t test:types ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-04 10:00:22 UTC

@Tobbe Tobbe enabled auto-merge (squash) January 4, 2026 09:47
@Tobbe Tobbe merged commit 0cb9398 into main Jan 4, 2026
42 checks passed
@Tobbe Tobbe deleted the tobbe-chore-ci-ssr-no-canary branch January 4, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants