Skip to content

adding support for pci class accelerator #6255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saijanani-c wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −0
Open

adding support for pci class accelerator #6255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions avocado/utils/pci.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ def get_pci_class_name(pci_address):
"0280": "net",
"0207": "net",
"0c03": "usb",
"1200": "accelerator",
Copy link

@gemini-code-assist gemini-code-assist bot Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this addition is correct, there are a couple of ways to improve the quality of this module:

  1. Testing: The get_pci_class_name function is not covered by unit tests in selftests/unit/utils/pci.py. Please add tests to verify this new 'accelerator' class and ideally the existing ones to prevent future regressions.

  2. Maintainability: The pci_class_dic could be improved by defining it as a module-level constant and keeping its keys sorted. This would improve performance by avoiding its recreation on every call and make it easier to maintain.

}
pci_class_id = get_pci_prop(pci_address, "Class")
if pci_class_id not in pci_class_dic:
Expand Down