adding support for pci class accelerator

[saijanani-c]

Summary by CodeRabbit

Release Notes

• New Features
  • Enhanced hardware device detection with improved support for accelerator device identification.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[gemini-code-assist]

Summary of Changes

Hello @saijanani-c, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the avocado utility's PCI device identification capabilities by introducing explicit support for the "accelerator" PCI class. This ensures that systems using this utility can accurately recognize and categorize accelerator hardware, improving device management and reporting.

Highlights

• PCI Class Identification: Added support for identifying PCI devices of class "accelerator" by mapping the class ID "1200" to its descriptive name within the pci_class_dic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

Walkthrough

A new PCI class ID mapping is added to the get_pci_class_name function in avocado/utils/pci.py. The class ID "1200" is mapped to the string "accelerator" in the class mapping dictionary. No modifications were made to function signatures, error handling, or control flow logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single dictionary entry addition to an existing mapping
• No logic changes or behavioral modifications
• Straightforward, isolated change with minimal context required

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding support for PCI class 1200 mapped to 'accelerator' in the get_pci_class_name function.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request correctly adds support for the 'accelerator' PCI class. My review includes a comment with suggestions to improve testing coverage and the maintainability of the PCI class dictionary, which would be beneficial to address.

[gemini-code-assist]

While this addition is correct, there are a couple of ways to improve the quality of this module:

1. Testing: The get_pci_class_name function is not covered by unit tests in selftests/unit/utils/pci.py. Please add tests to verify this new 'accelerator' class and ideally the existing ones to prevent future regressions.

2. Maintainability: The pci_class_dic could be improved by defining it as a module-level constant and keeping its keys sorted. This would improve performance by avoiding its recreation on every call and make it easier to maintain.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

avocado/utils/pci.py (1)

158-158: Add test coverage for the new "1200" PCI class mapping.

PCI class code 0x12 is officially designated for "Processing Accelerators." The mapping "1200": "accelerator" is correct and follows the existing naming convention in the dictionary (singular, lowercase entries). However, the test file does not currently include coverage for the get_pci_class_name() function, including this new mapping.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ac2f2d and 76d210b.

📒 Files selected for processing (1)

• avocado/utils/pci.py (1 hunks)

[clebergnu]

/packit copr-build