-
Notifications
You must be signed in to change notification settings - Fork 973
[QDP] Add libtorch workflow #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: 400Ping <fourhundredping@gmail.com>
| - name: Install dependencies | ||
| run: uv sync --group dev | ||
|
|
||
| - name: Install libtorch (CPU) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you help explain some context about this change? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can understand why in the PyTorch input format PR, the CI need libtorch to check the PR.
error: failed to run custom build command for `torch-sys v0.15.0`
Caused by:
process didn't exit successfully: `/home/runner/work/mahout/mahout/qdp/target/debug/build/torch-sys-7269c6cf50fd2453/build-script-build` (exit status: 1)
--- stdout
cargo:rerun-if-env-changed=LIBTORCH_USE_PYTORCH
cargo:rerun-if-env-changed=LIBTORCH
--- stderr
Error:
Cannot find a libtorch install, you can either:
- Install libtorch manually and set the LIBTORCH environment variable to appropriate path.
- Use a system wide install in /usr/lib/libtorch.so.
- Use a Python environment with PyTorch installed by setting LIBTORCH_USE_PYTORCH=1
See the readme for more details:
https://github.com/LaurentMazare/tch-rs/blob/main/README.md
warning: build failed, waiting for other jobs to finish...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update.
| - name: Install dependencies | ||
| run: uv sync --group dev | ||
|
|
||
| - name: Install libtorch (CPU) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update.
Purpose of PR
The PyTorch input format requires this CI workflow to test pre-commit
Related Issues or PRs
Related to #815
Changes Made
Breaking Changes
Checklist