Skip to content

Conversation

@400Ping
Copy link
Contributor

@400Ping 400Ping commented Jan 13, 2026

Purpose of PR

The PyTorch input format requires this CI workflow to test pre-commit

Related Issues or PRs

Related to #815

Changes Made

  • Bug fix
  • New feature
  • Refactoring
  • Documentation
  • Test
  • CI/CD pipeline
  • Other

Breaking Changes

  • Yes
  • No

Checklist

  • Added or updated unit tests for all changes
  • Added or updated documentation for all changes
  • Successfully built and ran all unit tests or manual tests locally
  • PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
  • Code follows ASF guidelines

Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping
Copy link
Contributor Author

400Ping commented Jan 13, 2026

@400Ping 400Ping mentioned this pull request Jan 13, 2026
14 tasks
- name: Install dependencies
run: uv sync --group dev

- name: Install libtorch (CPU)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help explain some context about this change? Thanks.

Copy link
Contributor Author

@400Ping 400Ping Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can understand why in the PyTorch input format PR, the CI need libtorch to check the PR.

error: failed to run custom build command for `torch-sys v0.15.0`

Caused by:
  process didn't exit successfully: `/home/runner/work/mahout/mahout/qdp/target/debug/build/torch-sys-7269c6cf50fd2453/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-env-changed=LIBTORCH_USE_PYTORCH
  cargo:rerun-if-env-changed=LIBTORCH

  --- stderr
  Error: 
  Cannot find a libtorch install, you can either:
  - Install libtorch manually and set the LIBTORCH environment variable to appropriate path.
  - Use a system wide install in /usr/lib/libtorch.so.
  - Use a Python environment with PyTorch installed by setting LIBTORCH_USE_PYTORCH=1

  See the readme for more details:
  https://github.com/LaurentMazare/tch-rs/blob/main/README.md

warning: build failed, waiting for other jobs to finish...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

- name: Install dependencies
run: uv sync --group dev

- name: Install libtorch (CPU)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@guan404ming guan404ming merged commit 19808a1 into apache:main Jan 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants