Skip to content

Conversation

@400Ping
Copy link
Contributor

@400Ping 400Ping commented Jan 12, 2026

Purpose of PR

As title

Related Issues or PRs

Related to #752

Changes Made

  • Bug fix
  • New feature
  • Refactoring
  • Documentation
  • Test
  • CI/CD pipeline
  • Other

Breaking Changes

  • Yes
  • No

Checklist

  • Added or updated unit tests for all changes
  • Added or updated documentation for all changes
  • Successfully built and ran all unit tests or manual tests locally
  • PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
  • Code follows ASF guidelines

Signed-off-by: 400Ping <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping 400Ping marked this pull request as draft January 12, 2026 19:42
Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping 400Ping marked this pull request as ready for review January 12, 2026 19:46
@400Ping
Copy link
Contributor Author

400Ping commented Jan 12, 2026

locally tested, should pass CI by now

@400Ping
Copy link
Contributor Author

400Ping commented Jan 13, 2026

I included the ci fix in the pr, because the current ci doesn't have PyTorch related installed.

Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping 400Ping mentioned this pull request Jan 13, 2026
14 tasks
Signed-off-by: 400Ping <fourhundredping@gmail.com>
@400Ping
Copy link
Contributor Author

400Ping commented Jan 13, 2026

locally tested, should pass CI by now

Need to add the CI check in this PR first #822

@400Ping
Copy link
Contributor Author

400Ping commented Jan 13, 2026

The current CI can't pass because it doesn't have libtorch.

400Ping and others added 5 commits January 14, 2026 11:33
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
@guan404ming
Copy link
Member

plz rebase and solve the precommit error, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants