-
Notifications
You must be signed in to change notification settings - Fork 973
[QDP] Simplify Python API with unified encode() method #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d28941 to
fe5206a
Compare
|
@guan404ming thanks for the patch! |
fe5206a to
76a80a1
Compare
|
I've updated with three additions. Please take another look, thanks!
|
|
Thanks for the update! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Overall lg, I agree with @rich7420 that it definitely needs refactor and can be a follow up!
400Ping
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
|
Thanks, I'll send a follow up for it. |
Purpose of PR
Why
How
Changes Made
Breaking Changes
Checklist