Skip to content

Conversation

@guan404ming
Copy link
Member

Purpose of PR

Related Issues or PRs

Changes Made

  • Bug fix
  • New feature
  • Refactoring
  • Documentation
  • Test
  • CI/CD pipeline
  • Other

Breaking Changes

  • Yes
  • No

Checklist

  • Added or updated unit tests for all changes
  • Added or updated documentation for all changes
  • Successfully built and ran all unit tests or manual tests locally
  • PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
  • Code follows ASF guidelines

@guan404ming guan404ming marked this pull request as ready for review January 12, 2026 13:29
@guan404ming guan404ming requested a review from rich7420 January 12, 2026 13:30
@guan404ming
Copy link
Member Author

cc @ryankert01 @400Ping

@viiccwen
Copy link
Contributor

Looks great!
I found current fn encode contains repeated 1D / 2D shape-matching logic across NumPy and PyTorch paths, which makes the function grow to ~150+ lines and slightly harder to scan at a glance.

Maybe it might be worth refactoring it into small helper functions in a follow-up PR?

I don’t think this needs to block the current change, just leaving this as a note for potential future cleanup : )

@guan404ming
Copy link
Member Author

Just go ahead for it thanks!

@guan404ming guan404ming merged commit d4a678d into apache:main Jan 12, 2026
2 checks passed
@guan404ming guan404ming deleted the fix/pytorch-shape-validation branch January 12, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants