Skip to content

Read AndroidX Snapshot ID from gradle.properties instead of env #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devbridie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Read AndroidX Snapshot ID from gradle.properties instead of env #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,7 @@ kotlin.code.style=official

# Enable R8 full mode.
android.enableR8.fullMode=true

# Use an AndroidX snapshot build.
# https://androidx.dev/snapshots/builds
# snapshotVersion=14793336
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To be consistent with the suggested change in settings.gradle.kts, this property name should also be updated to androidxSnapshotVersion for clarity and to avoid potential naming collisions in the future.

# androidxSnapshotVersion=14793336

2 changes: 1 addition & 1 deletion settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
val snapshotVersion: String? = System.getenv("COMPOSE_SNAPSHOT_ID")
val snapshotVersion: String? by settings
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The property name snapshotVersion is a bit generic. If you need to add other snapshot repositories in the future (e.g., for Kotlin), it could lead to naming conflicts. Consider renaming it to something more specific like androidxSnapshotVersion to clearly indicate its purpose. This will improve long-term maintainability.

Note that you will also need to update its usage on line 16.

val androidxSnapshotVersion: String? by settings


pluginManagement {
repositories {
Expand Down
Loading