Read AndroidX Snapshot ID from gradle.properties instead of env

[devbridie]

Hey,
I'd like to propose reading the AndroidX snapshot ID from settings.gradle.kts instead of from the system environment variables. If you switch to snapshot libraries, you need to update libs.versions.toml to switch to -SNAPSHOT version specifications. That means you should have also checked in the fact that you are swapping to a snapshot repository, which is not possible when reading from System environment variables.

I had an internal and external check for usages of COMPOSE_SNAPSHOT_ID, but couldn't find any.

[gemini-code-assist]

Summary of Changes

Hello @devbridie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the mechanism for specifying AndroidX snapshot versions within the project. By transitioning from environment variables to gradle.properties, it ensures that the snapshot ID is consistently defined and version-controlled alongside the project's other configuration, simplifying setup and collaboration for developers working with snapshot builds.

Highlights

• Configuration Source: The source for the AndroidX snapshot ID has been shifted from system environment variables (COMPOSE_SNAPSHOT_ID) to gradle.properties.
• Version Control: This change enables the snapshot version to be managed and committed directly within the project's version control system, improving consistency and discoverability.
• Gradle Configuration: settings.gradle.kts now reads the snapshotVersion using the settings delegate, aligning with the new gradle.properties source.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request proposes a good change to move the AndroidX snapshot ID configuration from an environment variable to gradle.properties. This makes the build configuration more explicit and version-controllable. My review includes a suggestion to make the new property name more specific to avoid potential naming conflicts in the future, which would improve the long-term maintainability of the build scripts.

[gemini-code-assist]

To be consistent with the suggested change in settings.gradle.kts, this property name should also be updated to androidxSnapshotVersion for clarity and to avoid potential naming collisions in the future.

# androidxSnapshotVersion=14793336

[gemini-code-assist]

The property name snapshotVersion is a bit generic. If you need to add other snapshot repositories in the future (e.g., for Kotlin), it could lead to naming conflicts. Consider renaming it to something more specific like androidxSnapshotVersion to clearly indicate its purpose. This will improve long-term maintainability.

Note that you will also need to update its usage on line 16.

val androidxSnapshotVersion: String? by settings