Skip to content

Conversation

@emrhnyz
Copy link

@emrhnyz emrhnyz commented Jan 28, 2026

Overview

This PR refactors the move_serial_arduino connector to improve robustness and expands the movement capabilities for serial-based robots. It introduces Pydantic for configuration validation and fixes an import path issue.

Type of change

  • Bug fix
  • New feature
  • Documentation improvement
  • Bounty issue submission
  • Other: Refactor

Changes

  • Refactored serial_arduino.py: - Implemented Pydantic configuration schema for validation (baudrate, timeout).
    • Added robust error handling (try-except blocks) to prevent crashes when the serial port is unavailable.
    • Replaced hardcoded values with configurable fields.
  • Expanded Interface: - Updated interface.py to support locomotion commands: WALK, TURN_LEFT, TURN_RIGHT, DANCE.
  • Bug Fix: - Corrected the import path in the connector to point to the local extended interface (actions.move_serial_arduino.interface) instead of the base module.

Checklist

  • Code complies with style guidelines
  • Self-review completed
  • Documentation updated (if applicable)
  • Local testing completed
  • Tests added/updated (if applicable)

Impact

These changes ensure that the serial connector does not crash the system when hardware is missing and allows developers to use OM1 with standard Arduino-based wheeled robots (walking/turning) reliably.

@emrhnyz emrhnyz requested review from a team as code owners January 28, 2026 20:41
@github-actions github-actions bot added robotics Robotics code changes python Python code labels Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Python code robotics Robotics code changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant