Fix several issues in server's get_local_address() #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of
get_local_address()has several issues:ip_addr) for every interface event if it's not the matching one. Solution - store address in a temporary variable (required because every next call toioctl()will resetifc.ifc_req[i]) and use it only for correct interface.ioctl()error, although it is not guaranteed thatioctl()will always return 0. E.g. some interface might fail withDevice not configured. Solution - just skip the interface instead of terminating.