Port server to Darwin: enable detection of MAC address over ioctl() #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes server to be compilable on Darwin (as well as on BSD-like systems). The PR #50 is required in order DIAL server to be able to start correctly. Server serves multicast & HTTP requests correctly. Unfortunately detection of "applications" doesn't works since it's based on the
/proc/file system.Nevertheless I believe it's worth enabling the server on Darwin, since it allows at least some rudimentary testing.
P.S. faking
SIOCGIFHWADDRis a hack but seems to be stable due to OS's backwards compatibility. Implementation of the IP/MAC detection viagetifaddrs()would be more preferable. However even it doesn't guarantee portability and requires distinguishing between AF_PACKET/AF_LINK (and sockaddr_ll/sockaddr_dl respectively).