feat: explore gene wise fdr #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explores the addition of pairwise fdr (meaning fdr on a single gene rather than across the whole dataset).
this change was suggested in the discord channel here https://discord.com/channels/1385383995704999947/1389397364401373335/1406996256378851468
exploration of the differences can be reproduced using this gist https://gist.github.com/drbh/d0c78d42adcc34562b242e34b76f80b5
Important
It's not clear if this should be merged (it does add more computational work), but wanted to open in case this ends up being helpful