Seperate Chromium and Edge UI's #175
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seperate the chromium and EDGE UI's into lorca.NewChromium and lorca.NewEdge so that the user can choose to use Edge instead of chrome when they have booth installed. Also, do not automatically add in all the default arguments. Instead make these public through AdditionalEdgeArgs and AdditionalChromiumArgs so that the user is not forced to use all the default arguments.
Split Chromium and Google Chrome because we may want to use them indepedetly.
Fix the UI HTML5 constructor. It was supposed to leverage the executable parameter instead of being hardcoded to be the chromium executable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seperate the chromium and EDGE UI's into lorca.NewChromium and
lorca.NewEdge so that the user can choose to use Edge instead of
chrome when they have booth installed. Also, do not automatically
add in all the default arguments. Instead make these public through
AdditionalEdgeArgs and AdditionalChromiumArgs so that the user is not
forced to use all the default arguments.