use the result of the broadcasted array to check the contents #3629
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isn't this the point? I'm implementing a super innefficient broadcast operation for my lazy array, but then i stuck on the fact that I didn't implement a very inefficient operation for `np.array_equal`
github-actions
bot
added
the
needs release notes
Contributor
|
@dcherian @TomAugspurger yall might want to have a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isn't this the point?
I'm implementing a super innefficient broadcast operation for my lazy array, but then i stuck on the fact that I didn't implement a very inefficient operation for
np.array_equalrelated to: #3627
The result of np.broadcast... is used in the if statement a few lines above.
Do I need to go through the todo?
docs/user-guide/*.mdchanges/