Fbx Camera Loader: No duplicated objects linked to scene collections

[moonyuet]

Changelog Description

This PR is to provide a quick fix to make sure no duplicated objects linked to scene collections.

Additional review information

As there is no duplicated object linked to scene collections.

Testing notes:

1. Load Camera (both abc and fbx)
2. Set version or update to the latest
3. The error should be gone

[LiborBatek]

All been working well and no issues were spotted. All good!

[LiborBatek]

@BigRoy here you have it while in ayon-blender 1.0.11 ...those products originates in maya but I guess it doesnt make any difference to any blender based ones too..

Loading_FBX_ABC_Camera.mp4

[LiborBatek]

@moonyuet @BigRoy how things are with this one? are we stuck for a reason?

[BigRoy]

So after some more investigating, I'm pretty sure the issue is that we're essentially trying to link it where it's already linked (but were than after unlinking it too?)

@moonyuet thoughts?
@LiborBatek can you test if the change seems good to Kayla - and then see if it does actually solve the issue at hand.

[BigRoy]

So I'm quite sure that I faced this same issue in another PR #214 which I tweaked here: 860200e

The issue of it already being linked - was that because by default it was already linked to parent because it is the active collection in some cases. And this active collection is where things are loaded into by default in blender so they were already linked, hence we can't link them again.

To avoid that ambiguous behavior I think we should just always unlink it from the active, and then link it to where we want it. Which means, just reversing the order of these here.

Suggested change

	if obj.name in parent.objects:
	self.log.info(
	"Object with name '%s' already exists in the scene. "
	"Skipping linking to the scene collection.",
	obj.name,
	)
	continue
	parent.objects.link(obj)
	collection.objects.unlink(obj)
	collection.objects.unlink(obj)
	parent.objects.link(obj)

[BigRoy]

Actually - note that this fix ... is already pushed upstream ;) so you can just test develop @LiborBatek because it should be fixed already. :) If so, then we can just close this PR.