-
-
Notifications
You must be signed in to change notification settings - Fork 49
Add performance benchmark for renderer extension matching #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: samdark <47294+samdark@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 289-double-extensions #293 +/- ##
========================================================
Coverage 99.14% 99.14%
Complexity 311 311
========================================================
Files 19 19
Lines 816 816
========================================================
Hits 809 809
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: samdark <47294+samdark@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Adds benchmarking infrastructure for the renderer extension matching logic introduced in #291 and #292, measuring the performance characteristics of the extension sorting and matching operations.
Changes
benchmarks/RendererMatchingBench.php - Benchmark suite measuring:
uksort()overhead for sorting extensions by length (~17.5 μs per operation)str_ends_with()performance for extension matching (~200 ns per operation)benchmarks/README.md - Documentation covering execution, interpretation, and performance trade-offs
Usage
Sample output:
The sorting overhead is acceptable since it occurs once during initialization, while the matching operation remains fast in the hot path.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.