Skip to content

Conversation

@samdark
Copy link
Member

@samdark samdark commented Jan 2, 2026

Newer versions of make are not filling MAKECMDGOALS the same way as older ones. This fix makes it work with both old and new versions.

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

Copilot AI review requested due to automatic review settings January 2, 2026 15:14
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.96%. Comparing base (b6bffee) to head (7cb96d2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #424   +/-   ##
=========================================
  Coverage     76.96%   76.96%           
  Complexity       29       29           
=========================================
  Files            11       11           
  Lines           178      178           
=========================================
  Hits            137      137           
  Misses           41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a compatibility issue with newer versions of make by changing how the default goal is determined when no goal is explicitly specified. The fix ensures the Makefile works correctly with both old and new make versions.

  • Refactored the logic to determine PRIMARY_GOAL by checking if $(firstword $(MAKECMDGOALS)) is empty rather than checking if MAKECMDGOALS itself is empty

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@samdark samdark merged commit 2cc1517 into master Jan 2, 2026
20 checks passed
@samdark samdark deleted the fix-make-help branch January 2, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants