-
-
Notifications
You must be signed in to change notification settings - Fork 62
Use PHP 8.5 for the base image #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
samdark
commented
Dec 25, 2025
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | - |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #423 +/- ##
=========================================
Coverage 76.96% 76.96%
Complexity 29 29
=========================================
Files 11 11
Lines 178 178
=========================================
Hits 137 137
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to upgrade the Docker base image from PHP 8.2 to PHP 8.5 for the FrankenPHP-based application. However, this change is problematic as PHP 8.5 has not been released yet.
Key Change:
- Updates the base Docker image from
dunglas/frankenphp:1-php8.2-bookwormtodunglas/frankenphp:1-php8.5-bookworm
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| FROM composer/composer:2-bin AS composer | ||
|
|
||
| FROM dunglas/frankenphp:1-php8.2-bookworm AS base | ||
| FROM dunglas/frankenphp:1-php8.5-bookworm AS base |
Copilot
AI
Dec 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base image dunglas/frankenphp:1-php8.5-bookworm is referenced only by a mutable tag, which makes the build dependent on whatever image is pushed to that tag in the future. If the upstream registry or image owner is compromised, an attacker could publish a malicious image under the same tag and your builds would consume it without any Dockerfile changes. To reduce supply chain risk, pin this dependency to an immutable image digest and, if possible, verify its provenance in your build pipeline.
vjik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? Minimal PHP version for template is 8.2.
|
Mainly because of initial installation using composer from Docker https://yiisoft.github.io/docs/guide/start/creating-project.html docker run --rm -it -v "$(pwd):/app" composer/composer create-project yiisoft/app your_project
sudo chown -R $(id -u):$(id -g) your_projectIn this case |
|
Solved with additional |