Skip to content

Add a url option when executing image action #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minhnhatspk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add a url option when executing image action #1426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae730c2
Add a url option when executing image action
minhnhatspk Mar 9, 2018
b10b7a3
build
minhnhatspk Mar 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dist/js/medium-editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3788,8 +3788,8 @@ MediumEditor.extensions = {};
// and provide similar access to a `fa-` icon default.
template.push(
'<div class="medium-editor-toolbar-form-row">',
'<input type="checkbox" class="medium-editor-toolbar-anchor-button">',
'<label>',
'<input type="checkbox" class="medium-editor-toolbar-anchor-button" id="medium-editor-toolbar-anchor-button-field-' + this.getEditorId() + '">',
'<label for="medium-editor-toolbar-anchor-button-field-' + this.getEditorId() + '">',
this.customClassOptionText,
'</label>',
'</div>'
Expand Down Expand Up @@ -7162,7 +7162,7 @@ MediumEditor.extensions = {};
}

if (action === 'image') {
var src = this.options.contentWindow.getSelection().toString().trim();
var src = this.options.contentWindow.getSelection().toString().trim() || opts.url;
return this.options.ownerDocument.execCommand('insertImage', false, src);
}

Expand Down
2 changes: 1 addition & 1 deletion src/js/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@
}

if (action === 'image') {
var src = this.options.contentWindow.getSelection().toString().trim();
var src = this.options.contentWindow.getSelection().toString().trim() || opts.url;
return this.options.ownerDocument.execCommand('insertImage', false, src);
}

Expand Down