Skip to content

feat(87): added adaptive to pkg.modal (ModalOverlay) #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unknownproperty merged 3 commits into from
Dec 27, 2025
+6 −7
Merged

feat(87): added adaptive to pkg.modal (ModalOverlay) #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3cb241
feat(87): added adaptive to pkg.modal (ModalOverlay)
ASTRAone Dec 14, 2025
13881b2
fix(87): fixed name property on ModalOverlay
ASTRAone Dec 17, 2025
f08f3bc
fix(87): up version on pkg.modal
ASTRAone Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 4 additions & 5 deletions packages/pkg.modal/components/ModalOverlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import React from 'react';
import { DialogOverlay } from '@radix-ui/react-dialog';
import { cn } from '@xipkg/utils';
import { cva, type VariantProps } from 'class-variance-authority';
import { DialogOverlay } from '@radix-ui/react-dialog';
import React from 'react';

export const modalOverlayVariants = cva(
'border-gray-5 flex flex-col space-y-2 border-b p-6 text-left bg-gray-0',
'border-gray-5 flex flex-col space-y-2 border-b p-6 max-sm:p-4 text-left bg-gray-0',
{
variants: {
overlayVariant: {
Expand All @@ -20,8 +20,7 @@ export const modalOverlayVariants = cva(
);

export interface ModalHeaderProps
extends React.ComponentProps<typeof DialogOverlay>,
VariantProps<typeof modalOverlayVariants> {}
extends React.ComponentProps<typeof DialogOverlay>, VariantProps<typeof modalOverlayVariants> {}

export const ModalOverlay = ({ overlayVariant, className, ...props }: ModalHeaderProps) => (
<DialogOverlay className={cn(modalOverlayVariants(), className)} {...props} />
Expand Down
2 changes: 1 addition & 1 deletion packages/pkg.modal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@xipkg/modal",
"version": "4.3.0",
"version": "4.3.1",
"main": "./dist/index.mjs",
"module": "./dist/index.mjs",
"types": "./dist/index.d.mts",
Expand Down