50: change error return #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Comment on lines
145
to
151
| if (validationError) { | ||
| onError(validationError); | ||
| if(typeof validationError === 'string'){ | ||
| onFileError(validationError); | ||
| }else{ | ||
| onFileError(validationError.titleError, validationError.subtitleError); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Что-то случилось с форматированием
| const validationError = validateBeforeUpload(fileList); | ||
| if (validationError) { | ||
| onError(validationError); | ||
| if(typeof validationError === 'string'){ |
Contributor
There was a problem hiding this comment.
Странно делать проверку, что valisationError строка, если ты в типизации указал, что точно нет
packages/pkg.fileuploader/types.ts
Outdated
| descriptionText?: string; | ||
| onChange: (files: File[]) => void; | ||
| validateBeforeUpload?: (files: File[]) => string | undefined; | ||
| validateBeforeUpload?: (files: File[]) => ValidationError | undefined; |
Contributor
There was a problem hiding this comment.
Мы в целом не используем undefined в коде ни для типов, ни для данных. Если мы хотим показать, что чего-то нет, то это null
|
|
||
| const handleError = (fileList: File[]): boolean => { | ||
| if (!enableErrorHandling || !onError) { | ||
| if (!enableErrorHandling || !onFileError) { |
Contributor
There was a problem hiding this comment.
Как будто с такой проверкой у тебя не будет отрабатывать validateBeforeUpload, даже если он есть
unknownproperty
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.