-
Notifications
You must be signed in to change notification settings - Fork 7
Making it possible to compile without Embree enabled #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b401c21 to
33d4613
Compare
|
I started this PR just trying to re-organise the structure of the Embree specific headers and source files but I then started taking it further by making the changes necessary to see if I could get XDG to compile without Embree enabled. This is proving to be a little more difficult than I had hoped as the I think it would be worth spending some more time getting the GPRT implementation up to speed before attempting to try and make it possible to compile XDG without Embree. Either way, I think there are a few nice QOL changes I've made in this PR which are separate enough to be split out into smaller PRs. |
gonuke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it seems like this is still on hold (maybe?), everything that is here seems pretty logical and valuable. I made a single comment about indentation (for readability) in the CMakeLists file.
|
Made a few more updates here so that tests which can only be run with the Embree backend are skipped when built with GPRT. This won't be evidenced by the current CI setup, but after #183 goes in I'll extend the CI matrix further to configure with Embree only , GPRT only, and Embree + GPRT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple suggests/minor points but i'm happy with the additional changes made here.
… re-add unit tests that don't require a ray tracer.
Not really a required PR but I feel like it makes sense from a place of wanting to keep things organised. There are a number of files which are embree specific which have currently been living in
include/xdgorsrcwhen they could be moved to their respectiveembree/directory.The only changes here are moving files to
embree/and changing headers/Cmake configuration to respect these changes. So from git's perspective lots of "renamed" files since their paths have changed.