Skip to content

Fix behavioural change introduced in v1 API with input validation in Email senders #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AfraHussaindeen wants to merge 1 commit into from
Closed

Fix behavioural change introduced in v1 API with input validation in Email senders #1047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../identity/api/server/notification/sender/v1/core/NotificationSenderManagementService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public EmailSender addEmailSender(EmailSenderAdd emailSenderAdd) {

EmailSenderDTO dto = buildEmailSenderDTO(emailSenderAdd);
try {
EmailSenderDTO emailSenderDTO = notificationSenderManagementService.addEmailSender(dto);
EmailSenderDTO emailSenderDTO = notificationSenderManagementService.addEmailSender(dto, false);
return buildEmailSenderFromDTO(emailSenderDTO);
} catch (NotificationSenderManagementException e) {
throw handleException(e);
Expand Down Expand Up @@ -236,7 +236,7 @@ public EmailSender updateEmailSender(String senderName, EmailSenderUpdateRequest

EmailSenderDTO dto = buildEmailSenderDTO(senderName, emailSenderUpdateRequest);
try {
EmailSenderDTO emailSenderDTO = notificationSenderManagementService.updateEmailSender(dto);
EmailSenderDTO emailSenderDTO = notificationSenderManagementService.updateEmailSender(dto, false);
return buildEmailSenderFromDTO(emailSenderDTO);
} catch (NotificationSenderManagementException e) {
throw handleException(e);
Expand Down
4 changes: 2 additions & 2 deletions .../identity/api/server/notification/sender/v2/core/NotificationSenderManagementService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public EmailSender addEmailSender(EmailSenderAdd emailSenderAdd) {

EmailSenderDTO dto = buildEmailSenderDTO(emailSenderAdd);
try {
EmailSenderDTO emailSenderDTO = notificationSenderManagementService.addEmailSender(dto);
EmailSenderDTO emailSenderDTO = notificationSenderManagementService.addEmailSender(dto, true);
Comment on lines 87 to +89
Copy link

@wso2-engineering wso2-engineering bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log Improvement Suggestion No: 3

Suggested change
EmailSenderDTO dto = buildEmailSenderDTO(emailSenderAdd);
try {
EmailSenderDTO emailSenderDTO = notificationSenderManagementService.addEmailSender(dto);
EmailSenderDTO emailSenderDTO = notificationSenderManagementService.addEmailSender(dto, true);
EmailSenderDTO dto = buildEmailSenderDTO(emailSenderAdd);
try {
log.info("Adding new email sender: " + emailSenderAdd.getName());
EmailSenderDTO emailSenderDTO = notificationSenderManagementService.addEmailSender(dto, true);

return buildEmailSenderFromDTO(emailSenderDTO);
} catch (NotificationSenderManagementException e) {
throw handleException(e);
Expand Down Expand Up @@ -248,7 +248,7 @@ public EmailSender updateEmailSender(String senderName, EmailSenderUpdateRequest

EmailSenderDTO dto = buildEmailSenderDTO(senderName, emailSenderUpdateRequest);
try {
EmailSenderDTO emailSenderDTO = notificationSenderManagementService.updateEmailSender(dto);
EmailSenderDTO emailSenderDTO = notificationSenderManagementService.updateEmailSender(dto, true);
Comment on lines 249 to +251
Copy link

@wso2-engineering wso2-engineering bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log Improvement Suggestion No: 4

Suggested change
EmailSenderDTO dto = buildEmailSenderDTO(senderName, emailSenderUpdateRequest);
try {
EmailSenderDTO emailSenderDTO = notificationSenderManagementService.updateEmailSender(dto);
EmailSenderDTO emailSenderDTO = notificationSenderManagementService.updateEmailSender(dto, true);
EmailSenderDTO dto = buildEmailSenderDTO(senderName, emailSenderUpdateRequest);
try {
log.info("Updating email sender: " + senderName);
EmailSenderDTO emailSenderDTO = notificationSenderManagementService.updateEmailSender(dto, true);

return buildEmailSenderFromDTO(emailSenderDTO);
} catch (NotificationSenderManagementException e) {
throw handleException(e);
Expand Down
Loading