Skip to content

fix(assets): hoist ?? inside JSON.stringify in virtual module codegen #15140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Princesseuh merged 2 commits into from
Jan 8, 2026
Merged

fix(assets): hoist ?? inside JSON.stringify in virtual module codegen #15140

Princesseuh merged 2 commits into from
Jan 8, 2026
+9 −4

Conversation

@cameronraysmith
Copy link
Contributor

@cameronraysmith cameronraysmith commented Jan 8, 2026 •
edited by ematipico
Loading

Closes #15136

@cameronraysmith
fix(assets): hoist nullish coalescing inside JSON.stringify
823befd 
Moves ?? fallbacks before serialization to eliminate dead code in
generated virtual module. Fixes esbuild suspicious-nullish-coalescing
warning.
@changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 5beaf2b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 8, 2026
@cameronraysmith
Copy link
Contributor Author

cameronraysmith commented Jan 8, 2026

Resolves

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 8, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing cameronraysmith:15136-fix (5beaf2b) with main (4eb6fc9)1

Summary

✅ 6 untouched benchmarks

Footnotes

  1. No successful run was found on main (8695285) during the generation of this report, so 4eb6fc9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@cameronraysmith cameronraysmith marked this pull request as ready for review January 8, 2026 05:09
@Princesseuh
Copy link
Member

Princesseuh commented Jan 8, 2026 •
edited
Loading

Looks great! Could you just add a changeset? Something like "Fixes esbuild warning due to dead code in assets virtual module". I'd normally add it for you, but I think you disabled permissions to your fork.

@trueberryless trueberryless mentioned this pull request Jan 8, 2026
Closed
1 task
@cameronraysmith
Copy link
Contributor Author

cameronraysmith commented Jan 8, 2026

done

Princesseuh
Princesseuh approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@Princesseuh Princesseuh merged commit 6f6f8f8 into withastro:main Jan 8, 2026
25 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 8, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Princesseuh Princesseuh Princesseuh approved these changes

Assignees

No one assigned

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[suspicious-nullish-coalescing] warning from dead ?? [] fallback in virtual module codegen

2 participants

@cameronraysmith @Princesseuh