fix(dev): preserve query params when base path is stripped

[leonace924]

Fixes #15095

Changes

• What does this change?

Updated baseMiddleware to ensure that after stripping the base path, the resulting URL always starts with / when it's not empty. This preserves query parameters and ensures proper URL parsing downstream.

After:

let newUrl = url.replace(devRoot, devRootReplacement);
// Ensure the URL is a valid path (e.g., /base?foo=bar -> /?foo=bar, not ?foo=bar)
if (newUrl !== '' && !newUrl.startsWith('/')) {
    newUrl = '/' + newUrl;
}
req.url = newUrl;

• packages/astro/src/vite-plugin-astro-server/base.ts: Added logic to prepend / when the stripped URL doesn't start with / and isn't empty
• packages/astro/src/vite-plugin-astro-server/request.ts: Already had normalization logic that handles the empty string pathname case (no changes needed)
• packages/astro/test/units/routing/trailing-slash.test.js: Test already exists for this scenario (issue Query params trigger 404 error in dev #15095)

Testing

The fix ensures that:

1. /base?query=test → strips to /?query=test → normalizes to empty string pathname for route matching ✅
2. /base → strips to empty string → normalizes correctly ✅
3. /base/ → strips to / → normalizes correctly ✅

• tested with minimal example

Docs

Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=42954461

[changeset-bot]

🦋 Changeset detected

Latest commit: 9926b6b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[leonace924]

@florian-lefebvre can you review my PR? please give me feedback
Thank you for your time

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing leonace924:fix/trailing-slash (9926b6b) with main (4eb6fc9)¹}

Summary

✅ 6 untouched benchmarks

Footnotes

1. No successful run was found on main (8695285) during the generation of this report, so 4eb6fc9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[florian-lefebvre]

Hi, some tests are not passing. Can you fix them first?

[leonace924]

@florian-lefebvre I’ve added the test screenshot; please review it again.
All tests have passed.
Thank you for your time.

[leonace924]

Hi @florian-lefebvre would you review once more?
I noticed this test error is not related to my changes...

[florian-lefebvre]

These tests are flaky, nothing to worry about. Thank you!