WPB-23018 - additional config options for ingress-nginx #4972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
jschaul
approved these changes
Jan 22, 2026
Member
jschaul
left a comment
jschaul
left a comment
There was a problem hiding this comment.
Looks fine. Note that the main changes for ingress ciphers are here: https://github.com/wireapp/wire-server/blob/develop/charts/ingress-nginx-controller/values.yaml#L46 but I suppose it's on purpose to not modify these.
This needs to be merged and run through its pipelines before you can use it in cailleach.
Contributor
Author
|
Exactly, I'd like to test a scenario where only the new curves are available to figure out what the potential impact might be and wanted to be fairly surgical where I applied this to keep the blast radius low |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for custom ingress annotations in the nginx-ingress-services chart via a new ingressAnnotations field. This enables per-environment TLS configuration (such as post-quantum key exchange curves) through server-snippet annotations without modifying the shared ingress-nginx controller.
Checklist
changelog.d