replace String#concat with Array#push to avoid frozen string violation
#582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation with Ruby 3.0 strings are frozen by default causing the catalog compiler to throw errors when one of the native corosync module types is used. this change replaces the use of the string concatenation operator with an array that gets joined into a string for further use. the functionality and data passed to external systems should remain unchanged, making this change backwards compatible.
UiP9AV6Y
force-pushed
the
feature/array_string_builder
branch
from
d44ae6b to
74e2890
Compare
Contributor
|
We are also running into issues with Ruby complaining about frozen string violations. So +1 from me for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
with Ruby 3.0 strings are frozen by default causing the catalog compiler to throw errors when one of the native corosync module types is used.
this change replaces the use of the string concatenation operator with an array that gets joined into a string for further use.
the functionality and data passed to external systems should remain unchanged, making this change backwards compatible.
This Pull Request (PR) fixes the following issues
n/a