Fix build with libc++ 19 #748
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes emulators/open-vm-tools to fail to compile with clang 19 and libc++ 19. This can be fixed by using the standard type std::u16string for UTF-16 strings, instead of (effectively) std::basic_string<uint16_t>. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in the libc++ 19 release notes [1], std::char_traits<> is now
only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
instantiation for other types will fail.
This causes emulators/open-vm-tools to fail to compile with clang 19 and
libc++ 19.
This can be fixed by using the standard type std::u16string for UTF-16
strings, instead of (effectively) std::basic_string<uint16_t>.
[1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals