Skip to content

Conversation

@matthiasblaesing
Copy link

  • trailing commas in arrays are now explicitly allowed (https://toml.io/en/v1.1.0#array)
  • trailing commas in inline table declarations are explicitly allowed and can span multiple lines (https://toml.io/en/v1.1.0#inline-table)
  • test and build dependencies were bumped (not the runtime dependency for antlr)
  • javac release flag was activated to ensure code usage matches target classpath (this showed, that the source already targetted JDK 11, as String#isBlank is used)

- trailing commas in array and inline table declarations are explicitly
  allowed
- inline tables can span multiple lines
@matthiasblaesing
Copy link
Author

matthiasblaesing commented Dec 30, 2025

Just noticed a problem - returning to draft.

False alarm - the problem was in the cargo project parser from NetBeans. That had recursively added the current directory. The TOML parser was just the tip of the stack, that was visible in the traces.

@matthiasblaesing matthiasblaesing marked this pull request as draft December 30, 2025 23:12
@matthiasblaesing matthiasblaesing marked this pull request as ready for review December 30, 2025 23:33
@vieiro
Copy link
Owner

vieiro commented Jan 5, 2026

Hi @matthiasblaesing ,
Please allow me some more days to review this PR. Thanks!

@matthiasblaesing
Copy link
Author

@vieiro no problem.

The failing run was caused by junit version upgrades, that are not JDK 11 compatible (I ran with JDK 21 ...). I updated in place and changed updates for junit to 5.14.1 which built/tested successfully for me on JDK 11.

@vieiro
Copy link
Owner

vieiro commented Jan 13, 2026

Hi @matthiasblaesing . I'll be very busy during the following two weeks, so this will take some time. Please ping me here if this is urgent.

@matthiasblaesing
Copy link
Author

@vieiro no worries! There is no rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants