Skip to content

fix: use byte.Buffer as the Write method can be called multiple times #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shieldwed wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: use byte.Buffer as the Write method can be called multiple times #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,11 @@ func (c *Client) Middleware(next http.Handler) http.Handler {
next.ServeHTTP(rw, r)

statusCode := rw.statusCode
value := rw.body
now := time.Now()
expires := now.Add(c.ttl)
if statusCode < 400 {
response := Response{
Value: value,
Value: rw.body.Bytes(),
Header: rw.Header(),
Expiration: expires,
LastAccess: now,
Expand Down Expand Up @@ -297,7 +296,7 @@ func ClientWithExpiresHeader() ClientOption {
type responseWriter struct {
http.ResponseWriter
statusCode int
body []byte
body bytes.Buffer
}

func (w *responseWriter) WriteHeader(statusCode int) {
Expand All @@ -306,6 +305,6 @@ func (w *responseWriter) WriteHeader(statusCode int) {
}

func (w *responseWriter) Write(b []byte) (int, error) {
w.body = b
w.body.Write(b)
return w.ResponseWriter.Write(b)
}