smaller dendritic template #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the dendritic template by consolidating module definitions and removing redundant files. The changes move the flake module definition from templates to the main modules directory and streamline the template's module structure.
- Consolidates flake module configuration into a new
modules/flakeModule.nixfile - Removes separate
target.nixanddendritic.nixmodules from the template - Merges configuration into the template's
checkmate.nixfile
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| templates/dendritic/checkmate/modules/target.nix | Removed - target configuration moved to checkmate.nix |
| templates/dendritic/checkmate/modules/dendritic.nix | Removed - dendritic import consolidated into main flakeModule |
| templates/dendritic/checkmate/modules/checkmate.nix | Updated to configure target input and import checkmate module |
| modules/templates.nix | Removed flakeModule definition (moved to separate file) |
| modules/flakeModule.nix | New file containing consolidated flakeModule definition with checkmate configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| flake-file.inputs.checkmate.url = lib.mkDefault "github:vic/checkmate"; | ||
| flake-file.inputs.target.url = "github:vic/checkmate?dir=templates/dendritic"; | ||
| imports = [ (inputs.checkmate.flakeModule or { }) ]; |
There was a problem hiding this comment.
The input is named target on line 3, but line 4 imports from inputs.checkmate. This creates an inconsistency - either the input should be named checkmate to match the import, or the import should use inputs.target to match the input name.
Suggested change
| imports = [ (inputs.checkmate.flakeModule or { }) ]; | |
| imports = [ (inputs.target.flakeModule or { }) ]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.